Re: [evolution-patches] Patch for bug#246225 , bug#246227

[Arulanandan P <arulanandan gmail com>]

hi 

       removed the column titles as per ur suggestion . i ve made the necessary changes . 

       attached the revised patch


bye
arulanandan

On 8/8/05, Not Zed <notzed ximian com> wrote:

This doesn't make sense btw (i missed it in the earlier patches), since
the rows of the filter rules are entirely *FREE FORM*.  They just
normally match these 3 things, but they needn't (and infact, don't).
Only the first column is ever anything consistently.

Whomever suggested it obviously has a limited understanding of what
they're looking at.


On Wed, 2005-08-03 at 22:06 +0530, Arulanandan P wrote:
>        /* adds title to the columns in the table of criteria : Field ,
> Condition , Value */
> +        columntitle = gtk_hbox_new(FALSE,0);
> +
> +        label = gtk_label_new(_("Field")) ;
> +        gtk_box_pack_start (GTK_BOX (columntitle), label, FALSE,
> FALSE,45);
> +
> +        label = gtk_label_new(_("Condition"));
> +        gtk_box_pack_start( GTK_BOX(columntitle) , label ,
> FALSE ,FALSE ,50);
> +
> +        label =  gtk_label_new(_("Value"));
> +        gtk_box_pack_start(GTK_BOX(columntitle) , label , FALSE ,
> FALSE , 75 );/* packs the column titles to the hbox */
> +
--
adfa(evolution-2.4:20087): gtkhtml-WARNING **: cannot find icon:
'stock_insert-url' in gnome

Index: filter-rule.c
===================================================================
RCS file: /cvs/gnome/evolution/filter/filter-rule.c,v
retrieving revision 1.68
diff -u -p -r1.68 filter-rule.c
--- filter-rule.c	16 May 2005 06:14:34 -0000	1.68
+++ filter-rule.c	19 Aug 2005 15:21:40 -0000
@@ -788,7 +788,7 @@ get_widget (FilterRule *fr, struct _Rule
 	   rule parts need to be a vbox */
 	vbox = gtk_vbox_new (FALSE, 6);
 
-	label = gtk_label_new_with_mnemonic (_("_Rule name:"));
+	label = gtk_label_new_with_mnemonic (_("_Search name:"));
 	name = gtk_entry_new ();
 	gtk_label_set_mnemonic_widget (label, name);
 
@@ -816,7 +816,7 @@ get_widget (FilterRule *fr, struct _Rule
 	gtk_box_pack_start (GTK_BOX (vbox), hbox, FALSE, FALSE, 0);
 	gtk_widget_show (hbox);
 
-	text = g_strdup_printf("<b>%s</b>", _("If"));
+	text = g_strdup_printf("<b>%s</b>", _("Find items that meet the following criteria"));
 	label = gtk_label_new (text);
 	gtk_label_set_use_markup (GTK_LABEL (label), TRUE);
 	gtk_misc_set_alignment (GTK_MISC (label), 0, 0.5);
@@ -855,9 +855,9 @@ get_widget (FilterRule *fr, struct _Rule
 	gtk_box_pack_start (GTK_BOX (hbox), add, FALSE, FALSE, 0);
 
 	if (f->flags & RULE_CONTEXT_GROUPING) {
-		const char *thread_types[] = { N_("if all criteria are met"), N_("if any criteria are met") };
+		const char *thread_types[] = { N_("If all criteria are met"), N_("If any criteria are met") };
 
-		label = gtk_label_new (_("Execute actions"));
+		label = gtk_label_new (_("Find items:"));
 		menu = gtk_menu_new ();
 	
 		for (i=0;i<2;i++) {
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/filter/ChangeLog,v
retrieving revision 1.426
diff -u -p -r1.426 ChangeLog
--- ChangeLog	9 Aug 2005 23:29:27 -0000	1.426
+++ ChangeLog	19 Aug 2005 15:40:32 -0000
@@ -1,3 +1,9 @@
+2005-08-19  Arulanandan P <arulanandan gmail com>
+
+	* filter-rule.c : Added the UI suggestions for "Advanced search" and "Save search"
+
+	* Fixes bugs   #246225  , #246227
+
 2005-08-10  Tor Lillqvist  <tml novell com>
 
 	* Makefile.am: Use privsolib instead of privlib. On Unix they are