[evolution-patches] fix for the bug #311904 [tasks]
- From: chen <pchenthill novell com>
- To: patches <evolution-patches lists ximian com>
- Subject: [evolution-patches] fix for the bug #311904 [tasks]
- Date: Tue, 09 Aug 2005 02:58:58 +0530
Hi,
Have attached the patch.
thanks, chenthill.
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/calendar/ChangeLog,v
retrieving revision 1.2789
diff -u -p -r1.2789 ChangeLog
--- ChangeLog 5 Aug 2005 12:15:33 -0000 1.2789
+++ ChangeLog 8 Aug 2005 21:13:43 -0000
@@ -1,3 +1,10 @@
+2005-08-09 Chenthill Palanisamy <pchenthill novell com>
+
+ Fixes #311904
+ * gui/dialogs/task-details-page.c:
+ (task_details_page_fill_component): Check if the date is
+ set before comparing it with current day for validation.
+
2005-08-05 Chenthill Palanisamy <pchenthill novell com>
* gui/e-cal-component-preview.c: (write_html): Using format
Index: gui/dialogs/task-details-page.c
===================================================================
RCS file: /cvs/gnome/evolution/calendar/gui/dialogs/task-details-page.c,v
retrieving revision 1.46
diff -u -p -r1.46 task-details-page.c
--- gui/dialogs/task-details-page.c 23 Jun 2005 09:11:05 -0000 1.46
+++ gui/dialogs/task-details-page.c 8 Aug 2005 21:13:46 -0000
@@ -416,21 +416,21 @@ task_details_page_fill_component (CompEd
&icalcomplete.month,
&icalcomplete.day);
- e_date_edit_get_time_of_day (E_DATE_EDIT (priv->completed_date),
- &icalcomplete.hour,
- &icalcomplete.minute);
+ if (date_set) {
+ e_date_edit_get_time_of_day (E_DATE_EDIT (priv->completed_date),
+ &icalcomplete.hour,
+ &icalcomplete.minute);
- /* COMPLETED today or before */
- icaltoday = icaltime_current_time_with_zone (zone);
- icaltimezone_convert_time (&icaltoday, zone,
- icaltimezone_get_utc_timezone());
+ /* COMPLETED today or before */
+ icaltoday = icaltime_current_time_with_zone (zone);
+ icaltimezone_convert_time (&icaltoday, zone,
+ icaltimezone_get_utc_timezone());
- if (icaltime_compare_date_only (icalcomplete, icaltoday) > 0) {
- comp_editor_page_display_validation_error (page, _("Completed date is wrong"), priv->completed_date);
- return FALSE;
- }
+ if (icaltime_compare_date_only (icalcomplete, icaltoday) > 0) {
+ comp_editor_page_display_validation_error (page, _("Completed date is wrong"), priv->completed_date);
+ return FALSE;
+ }
- if (date_set) {
/* COMPLETED must be in UTC, so we assume that the date in the
dialog is in the current timezone, and we now convert it
to UTC. FIXME: We should really use one timezone for the
@@ -438,7 +438,7 @@ task_details_page_fill_component (CompEd
changes the timezone, the COMPLETED date may get changed
as well. */
icaltimezone_convert_time (&icalcomplete, zone,
- icaltimezone_get_utc_timezone ());
+ icaltimezone_get_utc_timezone ());
e_cal_component_set_completed (comp, &icalcomplete);
} else {
e_cal_component_set_completed (comp, NULL);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]