Re: [evolution-patches] fix for for bug #310438



On Fri, 2005-08-05 at 06:30 -0600, Dinesh Layek wrote:
+       icalcomponent *tmp_icalcomp = NULL;
   This should be declared inside the following block 
 
if (e_cal_open (client, TRUE, NULL)) {d 
-                       
The calendar needs to be opened first before making any calls to it, the
call should not be removed.

> if (!e_cal_get_object (client, uid, NULL, &tmp_icalcomp, NULL)) {
The tmp_icalcomp should be freed using the icalcomponent_free, if the
component, if it returns TRUE. The error value should be checked here,
instead of passing NULL to it.

Please correct the typo errors in the ChangeLog


thanks, chenthill.




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]