Re: [evolution-patches] patch to fix #312190 (camel-groupwise)



On Tue, 2005-08-02 at 04:07 +0000, Vivek Jain  wrote:
It would be a good idea to use strlen() to get the length of JUNK_FOLDER
instead of a hard-coded value
>             /* we don't want to blindly copy the info: reset some
> flags not suitable for destination*/
> +                       if (!g_ascii_strncasecmp(source->full_name,
> JUNK_FOLDER, 9))
> +                               camel_folder_set_message_flags
> (source, old_uid, CAMEL_GW_MESSAGE_JUNK|CAMEL_MESSAGE_JUNK|
> CAMEL_MESSAGE_JUNK_LEARN, 0);

Looks ok otherwise.

Cheers,
partha



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]