Re: [evolution-patches] Fix for scalix provider in e-cal.c

["Carsten Guenther" <Carsten Guenther scalix com>]

Rodrigo Moya wrote:

> On Wed, 2005-04-06 at 09:43 -0700, Carsten Guenther wrote:
>  
>
> > Rodrigo Moya wrote:
> >
> >    
> >
> > > On Wed, 2005-04-06 at 11:56 +0530, Harish Krishnaswamy wrote:
> > >
> > >
> > >      
> > >
> > > > The current approach is ugly :(. This was meant to be a temporary hack
> > > > as we did not want to add a  gconf entry and preferred backends to have
> > > > flexibility in choosing the store. 
> > > > This patch looks good for now - the code does not allow backends to do
> > > > better. I will rework it at the earliest.
> > > >
> > > >   
> > > >
> > > >        
> > > there is one thing though, which is all those 'if' statements should
> > > probably be better 'if/else if' statements, so that we don't do all
> > > comparisons in all cases.
> > >
> > >
> > >      
> > Good point, I also added a g_free for the mangled_uri string. Patch 
> > attached.
> >
> >    
> this looks good to me
>  
Patch was commited to both the gnome-2-10 branch and the head.

Carsten

begin:vcard
fn:<b>Carsten Guenther</b>
n:Guenther;Carsten
org:<center><a href="http://www.scalix.com";><img border="0" src="http://www.scalix.com/images/logo.gif"/></a></center>
adr:Suite 602;;1400 Fashion Island Blvd;San Mateo;CA;94404;USA
email;internet:carsten guenther scalix com
x-mozilla-html:TRUE
url:http://www.scalix.com
version:2.1
end:vcard