Re: [evolution-patches] Fix for scalix provider in e-cal.c

[Rodrigo Moya <rodrigo novell com>]

On Wed, 2005-04-06 at 09:43 -0700, Carsten Guenther wrote:
> Rodrigo Moya wrote:
> 
> >On Wed, 2005-04-06 at 11:56 +0530, Harish Krishnaswamy wrote:
> >  
> >
> >>The current approach is ugly :(. This was meant to be a temporary hack
> >>as we did not want to add a  gconf entry and preferred backends to have
> >>flexibility in choosing the store. 
> >>This patch looks good for now - the code does not allow backends to do
> >>better. I will rework it at the earliest.
> >>
> >>    
> >>
> >there is one thing though, which is all those 'if' statements should
> >probably be better 'if/else if' statements, so that we don't do all
> >comparisons in all cases.
> >  
> >
> Good point, I also added a g_free for the mangled_uri string. Patch 
> attached.
> 
this looks good to me
-- 
Rodrigo Moya <rodrigo novell com>