Re: [evolution-patches] Fix for scalix provider in e-cal.c



On Wed, 2005-04-06 at 11:56 +0530, Harish Krishnaswamy wrote:
> The current approach is ugly :(. This was meant to be a temporary hack
> as we did not want to add a  gconf entry and preferred backends to have
> flexibility in choosing the store. 
> This patch looks good for now - the code does not allow backends to do
> better. I will rework it at the earliest.
> 
there is one thing though, which is all those 'if' statements should
probably be better 'if/else if' statements, so that we don't do all
comparisons in all cases.
-- 
Rodrigo Moya <rodrigo novell com>




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]