Re: [evolution-patches] Fix for scalix provider in e-cal.c

[Harish Krishnaswamy <kharish novell com>]

The current approach is ugly :(. This was meant to be a temporary hack
as we did not want to add a  gconf entry and preferred backends to have
flexibility in choosing the store. 
This patch looks good for now - the code does not allow backends to do
better. I will rework it at the earliest.

Thanks,
harish

On Wed, 2005-04-06 at 11:00 +0800, Not Zed wrote:
> 
> That is really odd, I think, that the code hardcodes this.  I wonder
> why it doesn't just use the protocol as a folder path so it works with
> any?
> 
> On Tue, 2005-04-05 at 13:31 -0700, Carsten Guenther wrote: 
> > Good day,
> > 
> > I hit a "minor" problem today while trying to get attachments to work. 
> > The client's local attachment stores are hard-coded in e-cal.c for the 
> > file backend, groupwise and exchange. So for our backend it returned 
> > NULL because there is no fallback. The fix is simple and a patch is 
> > attached to this mail. Please try to get this in for 2.2.2 as discussed 
> > with Christian in the chat.
> > 
> > Thanks a lot!
> > 
> > Carsten
> > 
> > text/plain attachment (e-cal.diff)
> > Index: e-cal.c
> > ===================================================================
> > RCS file: /cvs/gnome/evolution-data-server/calendar/libecal/e-cal.c,v
> > retrieving revision 1.94.2.2
> > diff -u -p -r1.94.2.2 e-cal.c
> > --- e-cal.c	15 Mar 2005 01:33:53 -0000	1.94.2.2
> > +++ e-cal.c	5 Apr 2005 20:28:03 -0000
> > @@ -1353,6 +1353,13 @@ set_local_attachment_store (ECal *ecal)
> >  		priv->local_attachment_store = g_strdup_printf ("file://%s/.evolution/exchange/%s", 
> >  					g_get_home_dir (), mangled_uri);
> >  	}
> > +
> > +        if (g_str_has_prefix (priv->uri, "scalix://")) {
> > +                priv->local_attachment_store = g_strdup_printf ("file://%s/.evolution/cache/scalix/%s/attach",
> > +                                        g_get_home_dir (), mangled_uri);
> > +        }
> > +
> > +	g_free (mangled_uri);
> >  }
> >  
> >  /**