Re: [evolution-patches] Fix for Evolution's new-mail-notify plugin to track changes to DBus API




I finally committed this (i figured the approval would be enough, maybe it got lost), to 2.10 and head.

As for the *1000 hack, i'd probably have used sed to convert it to some string form,  but i suppose while it works, this will do.

On Fri, 2005-03-11 at 20:16 -0500, David Malcolm wrote:
(cross-posted to evolution-patches and to the FreeDesktop dbus list)

Attached is a patch to Evolution that extracts the version of the DBus
API at configuration time as a preprocessor macro, and then uses it in
the new-mail-notify plugin to hack in an extra level of indirection in
the call to dbus_message_append_args if the DBus version is >=0.31

Somewhat ugly (but then Dbus doesn't yet offer an API stability
guarantee).

It multiplies the output from pkgconfig by 1000 since preprocessor
defines can't have decimal points in them - is there a saner way to do
this?

Dave Malcolm


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]