[evolution-patches] bbdb crash fix





simple bad function call usage.

the code seems to have quite a few failure case problems in general.


Index: plugins/bbdb/ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/plugins/bbdb/ChangeLog,v
retrieving revision 1.12
diff -u -p -r1.12 ChangeLog
--- plugins/bbdb/ChangeLog	7 Feb 2005 07:12:40 -0000	1.12
+++ plugins/bbdb/ChangeLog	5 Apr 2005 07:25:11 -0000
@@ -1,3 +1,8 @@
+2005-04-05  Not Zed  <NotZed Ximian com>
+
+	* bbdb.c (bbdb_handle_reply): noop if we can't open the book/we're
+	disabled.
+
 2005-02-07  JP Rosevear  <jpr novell com>
 
 	* org-gnome-evolution-bbdb.eplug.in: specify id
Index: plugins/bbdb/bbdb.c
===================================================================
RCS file: /cvs/gnome/evolution/plugins/bbdb/bbdb.c,v
retrieving revision 1.6
diff -u -p -r1.6 bbdb.c
--- plugins/bbdb/bbdb.c	31 Jan 2005 18:34:41 -0000	1.6
+++ plugins/bbdb/bbdb.c	5 Apr 2005 07:25:12 -0000
@@ -113,6 +113,8 @@ bbdb_handle_reply (EPlugin *ep, EMEventT
 
 	/* Open the addressbook */
 	book = bbdb_open_addressbook ();
+	if (book == NULL)
+		return;
 
 	cia = camel_mime_message_get_from (target->message);
 	for (i = 0; i < camel_address_length CAMEL_ADDRESS (cia); i ++) {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]