Re: [evolution-patches] [PATCH] folder-tree mark all as read plugin

[Not Zed <notzed ximian com>]

On Mon, 2005-04-04 at 16:12 +0200, Timo Hoenig wrote:
> Hi,
>
> On Mon, 2005-04-04 at 14:30 +0800, Not Zed wrote:
> > I really don't like the way this messageflags thing is used.  Just
> > pass both the mask and the set variables as arguments to the function,
> > as it is it makes it pretty unobvious from the calling code what is
> > going on when you 'set' the flag.
>
> Fixed.
>
> > Also, I suggest you use the newer interface of getting the
> > 'messageinfo' then setting the flag on the messageinfo
> > (camel_message_info_set_flags), rather than using this interface (as
> > in the inline documentation comments for this function, using
> > camel_folder_set_message_flags is deprecated, as it 'works' now).
>
> Fixed.
>
> > The strings need to be setup for translation too using i18ntool and
> > some other setup - see the e-plugin template that was posted to the
> > evolution blog, let me know if you can't find it and i'll dig it up
> > (most of the plugins aren't setup properly for this yet).
>
> OK. I've been playing around with i18n for a few hours.  The only
> solution I came up with is to integrate a sub-package
> in /plugins/$PLUGIN containing a `configure.ac` file and the usual
> suspects.  This really slows down the Evolution configure process since
> it requires something like the following in Evolution's `configure.in`:
>
> AC_CONFIG_SUBDIRS(plugins/folder-mark-as-read)
>
> Is this the way to go?  I'm wondering what happens if other plugins are
> using i18n, too -- actually there are none using i18n at the moment.

No they don't, and this is a problem which needs to be fixed.  I'm getting you to help iron out the problems so we can then apply it to all the plugins that require it ;-)

> I'd really like to clarify this issue before submitting a new patch.

Ok, no, this shouldn't be necessary.  You just need to add the .eplug.xml.in file to the toplevel configure.in and the right implicit rule in the Makefile.am in the plugin directory.

Thanks,
 Michael