Re: [evolution-patches] [PATCH] folder-tree mark all as read plugin

[Not Zed <notzed ximian com>]

I really don't like the way this messageflags thing is used.  Just pass both the mask and the set variables as arguments to the function, as it is it makes it pretty unobvious from the calling code what is going on when you 'set' the flag.

Also, I suggest you use the newer interface of getting the 'messageinfo' then setting the flag on the messageinfo (camel_message_info_set_flags), rather than using this interface (as in the inline documentation comments for this function, using camel_folder_set_message_flags is deprecated, as it 'works' now).

The strings need to be setup for translation too using i18ntool and some other setup - see the e-plugin template that was posted to the evolution blog, let me know if you can't find it and i'll dig it up (most of the plugins aren't setup properly for this yet).

And I think you're right, this will look a bit funny if you don't have it hidden sometimes.

I guess I also question the actual usefulness of the 'mark as unread' for the whole folder, it also seems a dangerous functiont o have next to a 'mark all as read' function.

On Sun, 2005-04-03 at 00:48 +0200, Timo Hoenig wrote:
>     +               camel_folder_set_message_flags (folder,
>     +                                                uids->pdata[i],
>     +                                                messageflags,
>     +                                                (messageflags & CAMEL_MESSAGE_DELETED) ? 0 : messageflags);
>