Re: [evolution-patches] Patch For Deleting Shared Folder Notifications

[Not Zed <notzed ximian com>]

Wont the below leak accept_data if the signal isn't connected?


        char *notification;
        char *start_message;
        char *buffer = NULL;
+       struct AcceptData *accept_data;
+       accept_data = g_new0(struct AcceptData, 1);
        
        if (!msg)
                return ;
@@ -210,7 +214,9 @@ org_gnome_popup_wizard (EPlugin *ep, EME
                        gnome_druid_append_page(wizard, GNOME_DRUID_PAGE(title_p
                        gtk_widget_show_all (GTK_WIDGET (title_page));
                        item_id = camel_mime_message_get_message_id (msg);
-                       g_signal_connect (title_page, "next", G_CALLBACK(accept_
+                       accept_data->item_id = item_id;
+                       accept_data->folder = target->folder;
+                       g_signal_connect (title_page, "next", G_CALLBACK(accept_
                } else 



On Mon, 2005-04-04 at 06:53 -0600, Pasupathilingam Sankarasivasubramanian wrote:
>     Hi, 
>      
>     The attached patch will delete the shared-folder notification messages on succesfully installing the shared folder. 
>     The install-shared.c file under shared-folder plugin is altered. Fixes the bug #73344 
>      
>     Thanks & Regards, 
>     Sankar P