Re: [evolution-patches] fix for the bug #73262 [calendar]

[Rodrigo Moya <rodrigo novell com>]

On Mon, 2005-04-04 at 15:14 +0530, chenthill wrote:
> Hi,
>   Have attached the fix for the bug.
> 
looks good, except for this:

> @@ -498,8 +510,10 @@ e_cal_backend_http_open (ECalBackendSync
>                 if (priv->mode == CAL_MODE_LOCAL)
>                         return GNOME_Evolution_Calendar_Success;
>  
> -               g_idle_add ((GSourceFunc) begin_retrieval_cb, cbhttp);
>         }
> +
> +       if (priv->mode == CAL_MODE_REMOTE)
> +               g_idle_add ((GSourceFunc) begin_retrieval_cb, cbhttp);
> 
you are already returning _Success if it's local in the first lines
above, so the check for == CAL_MODE_REMOTE seems to be redundant, and,
when the priv->cache object is not NULL, it will re-install the
begin_retrieval_cb idle function.
-- 
Rodrigo Moya <rodrigo novell com>