Re: [evolution-patches] Fix for "Not all deleted mails getting expunged"

[Not Zed <notzed ximian com>]

Yes the updates look fine to me.

Although the groupwise_sync function looks a bit funny, is there some cased where camel_message_info_free() is now called twice?  And where the 'items' list is created but never freed?

On Fri, 2005-04-01 at 10:43 +0530, Parthasarathi Susarla wrote:
> looks ok to me. 
> You can commmit it, once Michael approves it.
> Thanks,
> -partha
>
> On Thu, 2005-03-31 at 07:09 -0700, Pasupathilingam
> Sankarasivasubramanian wrote:
> > The attached patch is updated as per the review suggstion. The
> > function groupwise_sync is also updated. 
> >  
> > Thanks & Regards, 
> > Sankar P
> > 
> > >>>Not Zed <notzed ximian com> 03/31/05 8:21 am >>>
> > 
> > I suggest a simpler approach: just decrement the index 'i' when you
> > delete the message (this is what happens everywhere else).
> > 
> > Also, use camel_folder_summary_remove(summary, info) rather than the
> > 'uid' entry point, it is somewhat more efficient.  You still need to
> > unref the info like normal.
> > 
> > 
> > On Wed, 2005-03-30 at 22:33 -0700, Pasupathilingam
> > Sankarasivasubramanian wrote: 
> > >       
> > > 
> > > Hi,
> > >     
> > >     
> > > 
> > > 
> > >   
> > >   
> > > 
> > > The attached patch will fix the bug 74254. The bug is, when more than
> > > 
> > > 
> > > 
> > > one mails are deleted and expunged, not all the mails are getting
> > > 
> > > 
> > > 
> > > expunged.
> > > 
> > > 
> > > 
> > > 
> > > 
> > > groupwise_expunge function in camel-groupwise-folder is changed.
> > > 
> > > 
> > > 
> > > 
> > > 
> > > Regards,
> > > 
> > > 
> > > 
> > > Sankar P
> > > 
> > > 
> > >