Re: [evolution-patches] Patch about a11y bugs

[Rodrigo Moya <rodrigo novell com>]

On Thu, 2004-09-23 at 12:14 +0800, Li Yuan wrote:
> Hi, JP and Rodrigo
> 
> Now I have a patch in a11y directory for cvs HEAD. It  fixes some a11y 
> bugs. The patch has passed our internel review.
>
I understood last time you were going to have Sun approvals going also
to the e-p list, wasn't it that what we decided last time?

> Please help me to review it. Thanks a lot.
> 
> @@ -143,14 +144,14 @@
>         --n_events;
>         if (n_events > 0)
>                 g_snprintf (buffer, sizeof (buffer),
> -                           ", %d events", n_events);
> +                           _(", %d events"), n_events);
>
I think translators will complain about this string, because of
different usage of singular/plural in many languages.

> @@ -144,17 +145,17 @@
>         --n_events;
>         if (n_events > 0)
>                 g_snprintf (buffer, sizeof (buffer),
> -                           ", %d events", n_events);
> +                           _(", %d events"), n_events);
> 
ditto here

> @@ -279,7 +282,7 @@
>                                             &end_year, &end_month,
> &end_day)) {
>                 ++start_month;
>                 ++end_month;
> -               sprintf (new_name, "calendar (from %d-%d-%d to %d-%d-%
> d)",
> +               sprintf (new_name, _("calendar (from %d-%d-%d to %d-%
> d-%d)"),
> 
and here something similar might happen, due to the differences in date
formats.

The rest looks ok to me code-wise, not sure about the a11y correctness,
but if it passed your internal review, I guess you can commit to HEAD.
-- 
Rodrigo Moya <rodrigo novell com>