Re: [evolution-patches] 59717, evolution mail crash

[Jeffrey Stedfast <fejj ximian com>]

ah, suck. I'd forgotten all about this - and unfortunately this is
probably how it'd happen for first-time users?

Jeff

On Thu, 2004-09-09 at 22:41, Not Zed wrote:
> Ok, so there may be issues with this, but i haven't so far been able
> to create a situation where it is an issue.
> 
> Basically, if 'check supported authentication types' needs ask for any
> other user input whilst its running (e.g. ssl certs?  passwords?), the
> input request wont accept any input.
> 
> Shit eh ...
> 
> But if that never happens its ok.  I'm not sure ...
> 
> On Fri, 2004-09-03 at 12:31 +0800, Not Zed wrote:
> > Hi guys,
> > 
> > Another mailer crasher fix.
> > 
> > This is in two parts, one is low-risk but has unpleasant user
> > side-effects, the other part is higher risk and may need more
> > testing first but fixes the side-effects.
> > 
> > Making the dialogue modal fixes the nasty re-entrancy we can get in
> > this non-reentrant synchronous method - i tried various ways around
> > doing this but it got too complex, and as far as i can tell could
> > never work.  However when you connect to a host using SSL,
> > cancellation is a noop, so it can take 4 minutes to time out.  4
> > minutes in which time you can't do anything else.  e.g. if the user
> > put in the wrong hostname they're kind of stuck.
> > 
> > Which is where the second patch comes in, it enables cancellation
> > for a SSL connect.  Its only high risk in that this code has forever
> > caused lots of issues, so i'm not sure if the fix breaks it in
> > subtle ways.  I did some testing and it appears to work though - "i
> > don't see why it shouldn't work".  I guess it can wait till 2.0.1 if
> > need be.
> > 
> > Michael
> > 
> > -- 
> > 
> > Michael Zucchi <notzed ximian com>
> > "born to die, live to work, it's
> > all downhill from here"
> > Novell's Evolution and Free
> > Software Developer
> -- 
> 
> Michael Zucchi <notzed ximian com>
> "born to die, live to work, it's
> all downhill from here"
> Novell's Evolution and Free
> Software Developer