Re: [evolution-patches] Fix for the bug #65167 [calendar]

[Harish Krishnaswamy <kharish novell com>]

>-               if (priv->cnc && priv->cache) {
>+               /* if cache has been sucessfully loaded return back
without loading again */
>+               if (priv->cache_load_state) {
I guess you are losing the priv->cnc check here..that would create
problems when the cache is still present and a wrong password is
supplied.

BTW, why dont we just unref the cache, should the cache population fail
for some reason - which is what I think you are trying to address by
using the load_state.

>-       g_assert (default_zone != NULL);

You may perhaps need to replace the asserts (not remove them) by more
graceful checks.

regards,
harish





On Tue, 2004-09-07 at 11:12 +0530, chenthill wrote:
> Hi,
>       Have attached a fix for the bug 65167. We should put the
> default_zone back  into the cache since the task backend also needs
> the 
> default zone.
> 
> thanks, chenthill.