[evolution-patches] Patch for bugzilla bug 44876, mail and addressbook related

[Mengjie Yu <Meng-Jie Yu Sun COM>]

Hi

I have two patches for the bug 44876
http://bugzilla.ximian.com/show_bug.cgi?id=44876

please review it. 

Thanks.


mengjie yu

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/composer/ChangeLog,v
retrieving revision 1.666
diff -u -p -r1.666 ChangeLog
--- ChangeLog	20 Oct 2004 03:02:45 -0000	1.666
+++ ChangeLog	26 Oct 2004 08:54:55 -0000
@@ -1,3 +1,11 @@
+2004-10-26  mengjie yu  <meng-jie yu sun com>
+	
+	fix for bugzilla #44876
+
+	* e-msg-composer-hdrs.c (header_new_recipient), (create_headers): add access key for Reply_to,
+	From,Subject,To,Cc,Bcc,Post_to;
+	* e-msg-composer.c: (setup_signatures_menu):Add accesss key for Signature.
+
 2004-10-19  JP Rosevear  <jpr novell com>
 
 	* e-msg-composer.c, e-msg-composer-attachment-bar.c: convert to
Index: e-msg-composer-hdrs.c
===================================================================
RCS file: /cvs/gnome/evolution/composer/e-msg-composer-hdrs.c,v
retrieving revision 1.130
diff -u -p -r1.130 e-msg-composer-hdrs.c
--- e-msg-composer-hdrs.c	20 Sep 2004 05:59:54 -0000	1.130
+++ e-msg-composer-hdrs.c	26 Oct 2004 08:55:12 -0000
@@ -536,7 +536,7 @@ header_new_recipient (EMsgComposerHdrs *
 	
 	priv = hdrs->priv;
 	
-	ret.label = gtk_button_new_with_label (name);
+	ret.label = gtk_button_new_with_mnemonic (name);
 	GTK_OBJECT_UNSET_FLAGS (ret.label, GTK_CAN_FOCUS);
 	g_signal_connect_data (ret.label, "clicked",
 			       G_CALLBACK (address_button_clicked_cb),
@@ -567,7 +567,7 @@ static void
 create_headers (EMsgComposerHdrs *hdrs)
 {
 	EMsgComposerHdrsPrivate *priv = hdrs->priv;
-	
+	AtkObject *a11y;	
 	/*
 	 * Reply-To:
 	 *
@@ -575,36 +575,39 @@ create_headers (EMsgComposerHdrs *hdrs)
 	 * because that causes from_changed to be called, which
 	 * expects the reply_to fields to be initialized.
 	 */
-	priv->reply_to.label = gtk_label_new (_("Reply-To:"));
+	priv->reply_to.label = gtk_label_new_with_mnemonic (_("_Reply-To:"));
 	priv->reply_to.entry = gtk_entry_new ();
+	gtk_label_set_mnemonic_widget (priv->reply_to.label, priv->reply_to.entry);
 	
 	/*
 	 * From
 	 */
-	priv->from.label = gtk_label_new (_("From:"));
+	priv->from.label = gtk_label_new_with_mnemonic (_("Fr_om:"));
 	priv->from.entry = create_from_optionmenu (hdrs);
+	gtk_label_set_mnemonic_widget (priv->from.label, e_msg_composer_hdrs_get_from_omenu (hdrs));
 	
 	/*
 	 * Subject
 	 */
-	priv->subject.label = gtk_label_new (_("Subject:"));
+	priv->subject.label = gtk_label_new_with_mnemonic (_("S_ubject:"));
 	priv->subject.entry = gtk_entry_new ();
+	gtk_label_set_mnemonic_widget (priv->subject.label, priv->subject.entry);
 	g_signal_connect (priv->subject.entry, "changed",
 			  G_CALLBACK (entry_changed), hdrs);
-	
+
 	/*
 	 * To, CC, and Bcc
 	 */
 	priv->to = header_new_recipient (
-		hdrs, _("To:"),
+		hdrs, _("_To:"),
 		_("Enter the recipients of the message"));
 	
 	priv->cc = header_new_recipient (
-		hdrs, _("Cc:"),
+		hdrs, _("_Cc:"),
 		_("Enter the addresses that will receive a carbon copy of the message"));
 	
 	priv->bcc = header_new_recipient (
-		hdrs, _("Bcc:"),
+		hdrs, _("_Bcc:"),
 		 _("Enter the addresses that will receive a carbon copy of "
 		   "the message without appearing in the recipient list of "
 		   "the message."));
@@ -612,7 +615,7 @@ create_headers (EMsgComposerHdrs *hdrs)
 	/*
 	 * Post-To
 	 */
-	priv->post_to.label = gtk_button_new_with_label (_("Post To:"));
+	priv->post_to.label = gtk_button_new_with_mnemonic (_("_Post To:"));
 	GTK_OBJECT_UNSET_FLAGS (priv->post_to.label, GTK_CAN_FOCUS);
 	g_signal_connect (priv->post_to.label, "clicked",
 			  G_CALLBACK (post_browser_clicked_cb), hdrs);
@@ -621,6 +624,10 @@ create_headers (EMsgComposerHdrs *hdrs)
 			      NULL);
 	
 	priv->post_to.entry = gtk_entry_new ();
+	a11y = gtk_widget_get_accessible (priv->post_to.entry);
+	if (a11y != NULL) {
+		atk_object_set_name (a11y, _("Post To:"));	
+	}
 	g_signal_connect(priv->post_to.entry, "changed",
 			 G_CALLBACK (post_entry_changed_cb), hdrs);
 }
Index: e-msg-composer.c
===================================================================
RCS file: /cvs/gnome/evolution/composer/e-msg-composer.c,v
retrieving revision 1.487
diff -u -p -r1.487 e-msg-composer.c
--- e-msg-composer.c	20 Oct 2004 03:02:45 -0000	1.487
+++ e-msg-composer.c	26 Oct 2004 08:56:13 -0000
@@ -2093,12 +2093,14 @@ setup_signatures_menu (EMsgComposer *com
 	EIterator *it;
 	
 	hbox = e_msg_composer_hdrs_get_from_hbox (E_MSG_COMPOSER_HDRS (composer->hdrs));
-	
-	label = gtk_label_new (_("Signature:"));
+
+	label = gtk_label_new_with_mnemonic (_("Si_gnature:"));
 	gtk_widget_show (label);
-	
+
 	composer->sig_menu = (GtkOptionMenu *) gtk_option_menu_new ();
-	
+
+	gtk_label_set_mnemonic_widget (label, composer->sig_omenu);
+
 	gtk_box_pack_end_defaults (GTK_BOX (hbox), (GtkWidget *) composer->sig_menu);
 	gtk_box_pack_end (GTK_BOX (hbox), label, FALSE, TRUE, 0);
 	hspace = gtk_hbox_new (FALSE, 0);

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/addressbook/ChangeLog,v
retrieving revision 1.1851
diff -u -p -r1.1851 ChangeLog
--- ChangeLog	21 Oct 2004 21:34:45 -0000	1.1851
+++ ChangeLog	26 Oct 2004 09:00:54 -0000
@@ -1,3 +1,10 @@
+2004-10-26  mengjie yu  <meng-jie yu sun com>
+
+	fix for bugzilla #44876
+
+	* gui/component/select-names/e-select-names-manager.c:
+	(e_select_names_manager_entry_new):add a atk name for the entry.
+
 2004-10-21  JP Rosevear  <jpr novell com>
 
 	* gui/widgets/eab-config.c (ecph_class_init): correct hook name
Index: gui/component/select-names/e-select-names-manager.c
===================================================================
RCS file: /cvs/gnome/evolution/addressbook/gui/component/select-names/e-select-names-manager.c,v
retrieving revision 1.65
diff -u -p -r1.65 e-select-names-manager.c
--- gui/component/select-names/e-select-names-manager.c	20 May 2004 01:16:30 -0000	1.65
+++ gui/component/select-names/e-select-names-manager.c	26 Oct 2004 09:00:55 -0000
@@ -199,6 +199,18 @@ e_select_names_manager_entry_new (ESelec
 	entry->id = g_strdup (id);
 
 	entry->entry = E_ENTRY (e_entry_new ());
+
+	if (atk_get_root () != NULL) {
+		AtkObject *a11y = atk_gobject_accessible_for_object (entry->entry->item);
+		if (a11y != NULL) {
+			gchar *text;
+			if (pango_parse_markup (id, -1, '_', NULL,
+					&text, NULL, NULL))  {
+				atk_object_set_name (a11y, text);
+				g_free (text);
+			}
+		}
+	}
 	text_model = e_select_names_text_model_new (model);
 	g_object_set(entry->entry,
 		     "model",          text_model, /* The entry takes ownership of the text model */