Re: [evolution-patches] Evolution calendar get_object_query optimizations

[Harish Krishnaswamy <kharish novell com>]

On Tue, 2004-10-26 at 00:47 +0200, Rodrigo Moya wrote:

> this is the work I am doing on the recurrences-work branch, so please,
> give up on this, since I'll have it finished this week, ready to be
> merged to HEAD.
sorry.. did not mean step on your work. This patch merely replaces some
wrapper calls with direct function calls and adds some early checks - so
that redundant queries to back-end are not made. No attempt has been to
modify the functionality, at least by purpose :)

Regressed the patch only for current functionalities ('Delete All
instances', 'Delete this instance' options for recurrences). They seem
to work fine. Not sure if its compatible with something new you are
planning to add.


> Also, unfortunately, this is wrong:
> we need to use e_cal_generate_instances_for_object to get back any
> detached recurrences, which e_cal_recur... does not return.
> 
fail to understand why this is wrong. 
e_cal_recur.. in the course of its execution generates the instances and
updates the view accordingly, ensuring the existing functionality is
preserved. Why do we need to get the recurrences back at the
e_cal_view_objects_added_cb function ? 

Am I missing something here ?

thanks,
harish