Re: [evolution-patches] [gtkhtml] #67022 line wrapping on CJK texts



Your patch looks good, please commit.

R.

On Tue, 2004-10-19 at 07:42 +0900, Changwoo Ryu wrote:
2004-10-18 (월), 18:45 +0200, Radek Doulík 쓰시길:

> This part seems to be unnecessarily slow:
> 
> > -						wl = clen + max_len;
> > +						wmax = MIN(clen + max_width, slen);
> > +						while (utf8_width (s, wmax - clen) > max_width)
> > +							wmax--;						
> > +						wl = wmax;
> 
> I think it will be better to have another helper function returning
> the lenght of string starting on s which is not exceeding max_width.

You're right.  Attached the revised patch, against gtkhtml 3.2.3.


--
Radek Doulík <rodo novell com>
Novell, Inc.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]