Re: [evolution-patches] [gtkhtml] #67022 line wrapping on CJK texts



Hi Changwoo,

thanks for your patch.

This part seems to be unnecessarily slow:

-						wl = clen + max_len;
+						wmax = MIN(clen + max_width, slen);
+						while (utf8_width (s, wmax - clen) > max_width)
+							wmax--;						
+						wl = wmax;

I think it will be better to have another helper function returning the lenght of string starting on s which is not exceeding max_width.

Cheers
Radek

On Sat, 2004-10-02 at 17:29 +0900, Changwoo Ryu wrote:
Patch attached.


--
Radek Doulík <rodo novell com>
Novell, Inc.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]