GNOME.org
 

[evolution-patches] patches about mail

Hi, NotZed

I resend these four patches(mail related a11y) to you.

It doesn't include the _'s patch. I will transfer it to you after anna's decision.

Please help me to review it again.


Thanks a lot.

Yours
Mengjie Yu


Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/mail/ChangeLog,v
retrieving revision 1.3501
diff -u -p -r1.3501 ChangeLog
--- ChangeLog	26 Nov 2004 15:54:53 -0000	1.3501
+++ ChangeLog	29 Nov 2004 08:42:51 -0000
@@ -1,3 +1,14 @@
+2004-11-29  Mengjie Yu  <meng-jie yu sun com>
+
+	* em-account-editor.c: (emae_option_toggle),
+	(emae_receive_options_item):add mnemonic for buttons.
+	* em-format-html-display.c: (efhd_attachment_button):add atk name
+	for the popup button.
+	* mail-account-gui.c: (mail_account_gui_build_extra_conf):add 
+	access key for checkbox.
+	* message-list.c: (message_list_construct):add a atk name for the
+	message list.
+
 2004-11-26  JP Rosevear  <jpr novell com>
 
 	* em-format.c: wrap printf's in debug defines
Index: em-account-editor.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/em-account-editor.c,v
retrieving revision 1.8
diff -u -p -r1.8 em-account-editor.c
--- em-account-editor.c	1 Nov 2004 20:58:47 -0000	1.8
+++ em-account-editor.c	29 Nov 2004 08:42:58 -0000
@@ -1639,10 +1639,8 @@ emae_option_toggle(EMAccountEditorServic
 	GtkWidget *w;
 
 	/* FIXME: how do we get the default value ever? */
-	w = g_object_new(gtk_check_button_get_type(),
-			 "label", text,
-			 "active", camel_url_get_param(url, name) != NULL,
-			 NULL);
+	w = gtk_check_button_new_with_mnemonic (text);
+	g_object_set_data ((GObject *)w, "active", camel_url_get_param (url, name) != NULL);
 	g_object_set_data((GObject *)w, "option-name", (void *)name);
 	g_signal_connect(w, "toggled", G_CALLBACK(emae_option_toggle_changed), service);
 	gtk_widget_show(w);
@@ -1785,7 +1783,7 @@ emae_receive_options_item(EConfig *ec, E
 	row = ((GtkTable *)parent)->nrows;
 
 	box = gtk_hbox_new(FALSE, 4);
-	w = gtk_check_button_new_with_label(_("Automatically check for _new mail every"));
+	w = gtk_check_button_new_with_mnemonic (_("Automatically check for _new mail every"));
 	emae_account_toggle_widget(emae, (GtkToggleButton *)w, E_ACCOUNT_SOURCE_AUTO_CHECK);
 	gtk_box_pack_start((GtkBox *)box, w, FALSE, FALSE, 0);
 
@@ -2067,7 +2065,7 @@ static EMConfigItem emae_editor_items[] 
 	{ E_CONFIG_SECTION, "10.receive/30.auth", "vbox179", emae_widget_glade },
 
 	/* Most sections for this is auto-generated fromt the camel config */
-	{ E_CONFIG_PAGE, "20.receive_options", N_("Receiving Options"), },
+	{ E_CONFIG_PAGE, "20.receive_options", N_("Receiving O_ptions"), },
 	{ E_CONFIG_SECTION_TABLE, "20.receive_options/10.mailcheck", N_("Checking for New Mail"), },
 	{ E_CONFIG_ITEM_TABLE, "20.receive_options/10.mailcheck/00.autocheck", NULL, emae_receive_options_item, },
 
@@ -2145,7 +2143,7 @@ static EMConfigItem emae_druid_items[] =
 	{ E_CONFIG_SECTION, "10.receive/30.auth", "vbox179", emae_widget_glade },
 
 	/* Most sections for this is auto-generated fromt the camel config */
-	{ E_CONFIG_PAGE, "20.receive_options", N_("Receiving Options"), },
+	{ E_CONFIG_PAGE, "20.receive_options", N_("Receiving O_ptions"), },
 	{ E_CONFIG_SECTION_TABLE, "20.receive_options/10.mailcheck", N_("Checking for New Mail"), },
 	{ E_CONFIG_ITEM_TABLE, "20.receive_options/10.mailcheck/00.autocheck", NULL, emae_receive_options_item, },
 
Index: em-format-html-display.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/em-format-html-display.c,v
retrieving revision 1.57
diff -u -p -r1.57 em-format-html-display.c
--- em-format-html-display.c	26 Nov 2004 15:01:12 -0000	1.57
+++ em-format-html-display.c	29 Nov 2004 08:43:03 -0000
@@ -1213,6 +1213,7 @@ efhd_attachment_button(EMFormatHTML *efh
 		{ NULL, 0, 0 },
 		{ "text/uri-list", 0, 1 },
 	};
+	AtkObject *a11y;
 
 	/* FIXME: handle default shown case */
 	d(printf("adding attachment button/content\n"));
@@ -1292,6 +1293,11 @@ efhd_attachment_button(EMFormatHTML *efh
 	button = gtk_button_new();
 	/*GTK_WIDGET_UNSET_FLAGS(button, GTK_CAN_FOCUS);*/
 	gtk_container_add((GtkContainer *)button, gtk_arrow_new(GTK_ARROW_DOWN, GTK_SHADOW_NONE));
+
+	a11y = gtk_widget_get_accessible (button);
+	atk_object_set_name (a11y, _("Attachment Button"));
+
+
 	g_signal_connect(button, "button_press_event", G_CALLBACK(efhd_attachment_popup), info);
 	g_signal_connect(button, "popup_menu", G_CALLBACK(efhd_attachment_popup_menu), info);
 	g_signal_connect(button, "clicked", G_CALLBACK(efhd_attachment_popup_menu), info);
Index: mail-account-gui.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/mail-account-gui.c,v
retrieving revision 1.175
diff -u -p -r1.175 mail-account-gui.c
--- mail-account-gui.c	8 Oct 2004 15:56:18 -0000	1.175
+++ mail-account-gui.c	29 Nov 2004 08:43:13 -0000
@@ -1091,7 +1091,7 @@ mail_account_gui_build_extra_conf (MailA
 					enable_widget = path_label;
 				} else {
 					/* make a new label */
-					label = gtk_label_new (entries[i].text);
+					label = gtk_label_new_with_mnemonic (entries[i].text);
 					gtk_table_resize (cur_table, cur_table->nrows + 1, 2);
 					gtk_table_attach (cur_table, label, 0, 2, rows, rows + 1,
 							  GTK_EXPAND | GTK_FILL, 0, 0, 0);
@@ -1106,7 +1106,7 @@ mail_account_gui_build_extra_conf (MailA
 			GtkWidget *checkbox;
 			gboolean active;
 			
-			checkbox = gtk_check_button_new_with_label (entries[i].text);
+			checkbox = gtk_check_button_new_with_mnemonic (entries[i].text);
 			if (url)
 				active = camel_url_get_param (url, entries[i].name) != NULL;
 			else
@@ -1143,9 +1143,10 @@ mail_account_gui_build_extra_conf (MailA
 				entry = path;
 			} else {
 				/* make a new text entry with label */
-				label = gtk_label_new (entries[i].text);
+				label = gtk_label_new_with_mnemonic (entries[i].text);
 				gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.0);
 				entry = gtk_entry_new ();
+				gtk_label_set_mnemonic_widget (label, entry);
 				
 				gtk_table_attach (cur_table, label, 0, 1, rows, rows + 1,
 						  GTK_FILL, 0, 0, 0);
@@ -1211,7 +1212,7 @@ mail_account_gui_build_extra_conf (MailA
 			}
 			
 			hbox = gtk_hbox_new (FALSE, 0);
-			checkbox = gtk_check_button_new_with_label (pre);
+			checkbox = gtk_check_button_new_with_mnemonic (pre);
 			g_free (pre);
 			gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (checkbox), enable);
 			adj = gtk_adjustment_new (def, min, max, 1, 1, 1);
Index: message-list.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/message-list.c,v
retrieving revision 1.403
diff -u -p -r1.403 message-list.c
--- message-list.c	12 Nov 2004 05:54:07 -0000	1.403
+++ message-list.c	29 Nov 2004 08:43:24 -0000
@@ -1997,6 +1997,7 @@ message_list_class_init (MessageListClas
 static void
 message_list_construct (MessageList *message_list)
 {
+	AtkObject *a11y;
 	gboolean construct_failed;
 	message_list->model =
 		e_tree_memory_callbacks_new (ml_tree_icon_at,
@@ -2038,6 +2039,11 @@ message_list_construct (MessageList *mes
 	if (!construct_failed)
 		e_tree_root_node_set_visible (message_list->tree, FALSE);
 
+	if (atk_get_root () != NULL) {
+		a11y = gtk_widget_get_accessible (message_list->tree);
+		atk_object_set_name (a11y, _("Message List"));
+	}
+
 	g_signal_connect((message_list->tree), "cursor_activated",
 			 G_CALLBACK (on_cursor_activated_cmd),
 			 message_list);

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/e-util/ChangeLog,v
retrieving revision 1.503
diff -u -p -r1.503 ChangeLog
--- ChangeLog	26 Nov 2004 14:57:49 -0000	1.503
+++ ChangeLog	29 Nov 2004 08:43:49 -0000
@@ -1,3 +1,8 @@
+2004-11-29  Mengjie Yu  <meng-jie yu sun com>
+
+	* e-config.c: (ec_rebuild):add mnemonic for label.
+	* e-passwords.c: (ep_ask_password):add description for password dialog.
+
 2004-11-26  JP Rosevear  <jpr novell com>
 
 	* e-gui-utils.c (e_create_image_widget): get the image directly
Index: e-config.c
===================================================================
RCS file: /cvs/gnome/evolution/e-util/e-config.c,v
retrieving revision 1.10
diff -u -p -r1.10 e-config.c
--- e-config.c	26 Nov 2004 14:57:49 -0000	1.10
+++ e-config.c	29 Nov 2004 08:44:04 -0000
@@ -586,7 +586,7 @@ ec_rebuild(EConfig *emp)
 					page = ((GnomeDruidPageStandard *)w)->vbox;
 					connect = TRUE;
 				} else {
-					w = gtk_label_new(item->label);
+					w = gtk_label_new_with_mnemonic (item->label);
 					gtk_widget_show(w);
 					page = gtk_vbox_new(FALSE, 12);
 					gtk_container_set_border_width((GtkContainer *)page, 12);
Index: e-passwords.c
===================================================================
RCS file: /cvs/gnome/evolution/e-util/e-passwords.c,v
retrieving revision 1.22
diff -u -p -r1.22 e-passwords.c
--- e-passwords.c	13 Oct 2004 17:25:37 -0000	1.22
+++ e-passwords.c	29 Nov 2004 08:44:10 -0000
@@ -420,6 +420,7 @@ ep_ask_password(EPassMsg *msg)
 	GtkWidget *vbox;
 	int type = msg->flags & E_PASSWORDS_REMEMBER_MASK;
 	int noreply = msg->noreply;
+	AtkObject *a11y;
 
 	msg->noreply = 1;
 
@@ -442,6 +443,9 @@ ep_ask_password(EPassMsg *msg)
 	gtk_container_set_border_width((GtkContainer *)vbox, 6);
 	
 	msg->entry = gtk_entry_new ();
+
+	a11y = gtk_widget_get_accessible (msg->entry);
+	atk_object_set_description (a11y, msg->prompt);
 	gtk_entry_set_visibility ((GtkEntry *)msg->entry, !(msg->flags & E_PASSWORDS_SECRET));
 	gtk_entry_set_activates_default((GtkEntry *)msg->entry, TRUE);
 	gtk_box_pack_start (GTK_BOX (vbox), msg->entry, TRUE, FALSE, 3);

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/camel/ChangeLog,v
retrieving revision 1.2316
diff -u -p -r1.2316 ChangeLog
--- ChangeLog	25 Nov 2004 10:50:11 -0000	1.2316
+++ ChangeLog	29 Nov 2004 08:46:46 -0000
@@ -1,3 +1,7 @@
+2004-11-29  Mengjie Yu  <meng-jie yu sun com>
+
+	* providers/imap/camel-imap-provider.c:add mnemonic for checkboxes.
+
 2004-10-12  Radek Doulik  <rodo ximian com>
 
 	* camel-junk-plugin.c: new init method implementation
Index: providers/imap/camel-imap-provider.c
===================================================================
RCS file: /cvs/gnome/evolution/camel/providers/imap/camel-imap-provider.c,v
retrieving revision 1.31
diff -u -p -r1.31 camel-imap-provider.c
--- providers/imap/camel-imap-provider.c	20 Sep 2004 05:59:54 -0000	1.31
+++ providers/imap/camel-imap-provider.c	29 Nov 2004 08:46:47 -0000
@@ -43,33 +43,33 @@ CamelProviderConfEntry imap_conf_entries
 	{ CAMEL_PROVIDER_CONF_SECTION_START, "mailcheck", NULL,
 	  N_("Checking for New Mail") },
 	{ CAMEL_PROVIDER_CONF_CHECKBOX, "check_all", NULL,
-	  N_("Check for new messages in all folders"), "1" },
+	  N_("C_heck for new messages in all folders"), "1" },
 	{ CAMEL_PROVIDER_CONF_SECTION_END },
 	{ CAMEL_PROVIDER_CONF_SECTION_START, "cmdsection", NULL,
 	  N_("Connection to Server") },
 	{ CAMEL_PROVIDER_CONF_CHECKBOX, "use_command", NULL,
-	  N_("Use custom command to connect to server"), "0" },
+	  N_("_Use custom command to connect to server"), "0" },
 	{ CAMEL_PROVIDER_CONF_ENTRY, "command", "use_command",
 	  N_("Command:"), "ssh -C -l %u %h exec /usr/sbin/imapd" },
 	{ CAMEL_PROVIDER_CONF_SECTION_END },
 	{ CAMEL_PROVIDER_CONF_SECTION_START, "folders", NULL,
 	  N_("Folders") },
 	{ CAMEL_PROVIDER_CONF_CHECKBOX, "use_lsub", NULL,
-	  N_("Show only subscribed folders"), "1" },
+	  N_("_Show only subscribed folders"), "1" },
 	{ CAMEL_PROVIDER_CONF_CHECKBOX, "override_namespace", NULL,
-	  N_("Override server-supplied folder namespace"), "0" },
+	  N_("O_verride server-supplied folder namespace"), "0" },
 	{ CAMEL_PROVIDER_CONF_ENTRY, "namespace", "override_namespace",
 	  N_("Namespace") },
 	{ CAMEL_PROVIDER_CONF_SECTION_END },
 	{ CAMEL_PROVIDER_CONF_SECTION_START, "general", NULL, N_("Options") },
 	{ CAMEL_PROVIDER_CONF_CHECKBOX, "filter", NULL,
-	  N_("Apply filters to new messages in INBOX on this server"), "0" },
+	  N_("_Apply filters to new messages in INBOX on this server"), "0" },
 	{ CAMEL_PROVIDER_CONF_CHECKBOX, "filter_junk", NULL,
-	  N_("Check new messages for Junk contents"), "0" },
+	  N_("Check new messages for _Junk contents"), "0" },
 	{ CAMEL_PROVIDER_CONF_CHECKBOX, "filter_junk_inbox", "filter_junk",
-	  N_("Only check for Junk messages in the INBOX folder"), "0" },
+	  N_("Only check for Junk messa_ges in the INBOX folder"), "0" },
 	{ CAMEL_PROVIDER_CONF_CHECKBOX, "offline_sync", NULL,
-	  N_("Automatically synchronize remote mail locally"), "0" },
+	  N_("Automatically synchroni_ze remote mail locally"), "0" },
 	{ CAMEL_PROVIDER_CONF_SECTION_END },
 	{ CAMEL_PROVIDER_CONF_END }
 };

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/filter/ChangeLog,v
retrieving revision 1.417
diff -u -p -r1.417 ChangeLog
--- ChangeLog	12 Aug 2004 20:35:30 -0000	1.417
+++ ChangeLog	29 Nov 2004 08:45:16 -0000
@@ -1,3 +1,7 @@
+2004-11-29  Mengjie Yu  <meng-jie yu sun com>
+
+	* filter-rule.c: (get_widget):add mnemonic widget in search box.
+
 2004-07-29  Carlos Garnacho Parro  <carlosg gnome org>
 
 	* filter-file.c: added the "use_filechooser" property to the 
Index: filter-rule.c
===================================================================
RCS file: /cvs/gnome/evolution/filter/filter-rule.c,v
retrieving revision 1.64
diff -u -p -r1.64 filter-rule.c
--- filter-rule.c	17 Jun 2004 07:34:07 -0000	1.64
+++ filter-rule.c	29 Nov 2004 08:45:24 -0000
@@ -787,9 +787,10 @@ get_widget (FilterRule *fr, struct _Rule
 	   rule parts need to be a vbox */
 	vbox = gtk_vbox_new (FALSE, 6);
 
-	label = gtk_label_new (_("Rule name:"));
+	label = gtk_label_new_with_mnemonic (_("_Rule name:"));
 	name = gtk_entry_new ();
-	
+	gtk_label_set_mnemonic_widget (label, name);
+
 	if (!fr->name) {
 		fr->name = g_strdup (_("Untitled"));
 		gtk_entry_set_text (GTK_ENTRY (name), fr->name);
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]