Re: [evolution-patches] Re: Save-calendar plugin: corrected GTK_STOCK_SAVE_AS behavior and support for comma seperated files

On Wed, 2004-11-24 at 10:50 +0100, Philip Van Hoof wrote:
> Heh .. I forgot to attach the patch itself.
> On Wed, 2004-11-24 at 10:49 +0100, Philip Van Hoof wrote:
> > Hi there,
> > 
> > This patch corrects the dialogs behavior to a GTK_STOCK_SAVE_AS. Notice
> > the title-change!
> > 
> > The issue is that the e_cal_new_from_uri () will create a directory. The
> > old title didn't tell the user about that. it simply stated: "Select
> > destination file". It will not be created as only a file. Rather a
> > directory with a file in it.
> > 
> > I've also added support for comma separated files as feature-requested
> > by this GNOME Bounty: 
> > 
> >
> >
> > 
> > This support was also in my previous save-calendar patches of 23 and 19
> > November. 
> > 
> > This new patch proposes a few GtkDialog-title-changes. Review them
> > first, of course.
> > 
> > ps. I've put the original authors as found in the ChangeLog in CC.
> > 
> > 

The person who should probably review this is away right now, but let me
give a few comments.

I think the the type for "Save As" should probably be set by a widget in
the save dialog, rather than via a submenu.  I also think we need to
work around the ical folder saving issue, either by picking the folder
correctly or altering the file backend to allow overriding of the file
name used on disk (right now it uses either calendar.ics or tasks.ics).

For CSV an option to insert a header row would be good and the date and
time spacing seems borked, its using " 6" instead of "06" for instance.
Descriptions don't seem to be written out properly either.

JP Rosevear <jpr novell com>
Novell, Inc.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]