Re: [evolution-patches] Patch for bug #127541 - Default Free Busy URI

[JP Rosevear <jpr novell com>]

On Thu, 2004-11-04 at 12:36 -0400, James Bowes wrote:
> Hi,
> 
> My apologies if this email has already reached the list, but I think the
> previous sending failed.
> 
> Attached is my submission for bug #127541: Default free/busy URI
> 
> This patch adds an additional preference under the Free/Busy Publish
> page in the calendar configuration preferences notebook, allowing you to
> specify the default uri template, and will substitute <USER> and
> <DOMAIN> with the respective parts of the attendee's email address.
> 
> I have also attached the patch to the bugzilla bug, before I was told by
> jpr that I should have sent it to this list.

Patches should include a ChangeLog.  In terms of UI, I think the
settings tab name should become just "Free/Busy" instead of "Free/Busy
Publishing" and the two bolded names should be "Publishing" and "Default
Free/Busy Server".  I'd like the informational text to be a little more
clear, maybe something like "the user and domain substitutions will be
taken from the email address".  The substitutions should maybe be in the
"%d" and "%u" forms, which is a more common substitution format, however
it does make them less immediately clear.

For the actual operation, perhaps you should add a notification in
calendar-config.[hc] that is listened to in e-meeting-store (or some
"controller") and issues a refresh call to rebuild the data.

You can't call the calendar_config call in freebusy_async because its in
a separate thread and gconf doesn't support this.  Perhaps store the
value in the store's private data instead? (Cuts down on the number of
gconf calls anyhow).

-JP
-- 
JP Rosevear <jpr novell com>
Novell, Inc.