Re: [evolution-patches] a gal patch

[Li Yuan <Li Yuan Sun COM>]

Li Yuan wrote:

> Hi JP,
>
> Here is a gal patch. It adds SUN keyboard support to gal and fixes a 
> little a11y bug.
> Please help me to review it.
> Thank you very much.
>
> Regards,
> Li
>
>  
Sorry, forgot a header file. Here is the new patch.

Regards,
Li

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/gal/ChangeLog,v
retrieving revision 1.900
diff -u -r1.900 ChangeLog
--- ChangeLog	10 Oct 2004 21:12:05 -0000	1.900
+++ ChangeLog	12 Nov 2004 03:13:37 -0000
@@ -1,3 +1,21 @@
+2004-11-12  Li Yuan  <li yuan sun com>
+
+	* gal/util/e-text-event-processor-emacs-like.c:
+	(e_text_event_processor_emacs_like_event):
+	Handle SUN Type 6 keyboard's copy, paste and cut key.
+	* gal/widgets/gal-combo-box.c: (gal_combo_box_init):
+	Set arrow button's a11y name.
+

 2004-10-10  Malcolm Tredinnick <malcolm commsecure com au>
 
 	* configure.in: Remove redundant call to AC_PROG_INTLTOOL and

Index: gal/util/e-text-event-processor-emacs-like.c
===================================================================
RCS file: /cvs/gnome/gal/gal/util/e-text-event-processor-emacs-like.c,v
retrieving revision 1.20
diff -u -r1.20 e-text-event-processor-emacs-like.c
--- gal/util/e-text-event-processor-emacs-like.c	1 Dec 2003 17:50:20 -0000	1.20
+++ gal/util/e-text-event-processor-emacs-like.c	12 Nov 2004 03:14:25 -0000
@@ -260,6 +260,18 @@
 				/* gtk_toggle_insert(text) -- IMPLEMENT -- FIXME */
 				}
 				break;
+			case GDK_F16:
+				command.action = E_TEP_COPY;
+				command.position = E_TEP_SELECTION;
+				break;
+			case GDK_F18:
+				command.action = E_TEP_PASTE;
+				command.position = E_TEP_SELECTION;
+				break;
+			case GDK_F20:
+				command.action = E_TEP_DELETE;
+				command.position = E_TEP_SELECTION;
+				break;
 			case GDK_Delete:
 			case GDK_KP_Delete:
 				if (key.state & GDK_CONTROL_MASK){
Index: gal/widgets/gal-combo-box.c
===================================================================
RCS file: /cvs/gnome/gal/gal/widgets/gal-combo-box.c,v
retrieving revision 1.2
diff -u -r1.2 gal-combo-box.c
--- gal/widgets/gal-combo-box.c	12 Feb 2004 17:02:31 -0000	1.2
+++ gal/widgets/gal-combo-box.c	12 Nov 2004 03:14:27 -0000
@@ -36,6 +36,7 @@
 #include <gtk/gtkvbox.h>
 #include <gtk/gtktearoffmenuitem.h>
 #include <gdk/gdkkeysyms.h>
+#include <libgnome/gnome-i18n.h>
 #include "gal-combo-box.h"
 #include "gal/util/e-util.h"

@@ -393,6 +393,7 @@
 {
 	GtkWidget *arrow;
 	GdkCursor *cursor;
+	AtkObject *atko;
 
 	combo_box->priv = g_new0 (GalComboBoxPrivate, 1);
 
@@ -409,6 +410,9 @@
 	g_signal_connect (combo_box->priv->arrow_button, "toggled",
 			  G_CALLBACK (gtk_combo_toggle_pressed), combo_box);
 	gtk_widget_show_all (combo_box->priv->arrow_button);
+	/* set the a11y name */
+	atko = gtk_widget_get_accessible (combo_box->priv->arrow_button);
+	atk_object_set_name (atko, _("Popup"));
 
 	/*
 	 * prelight the display widget when mousing over the arrow.