Re: [evolution-patches] Patch to clean up warnings from sparse in gtkhtml

[Kjartan Maraas <kmaraas broadpark no>]

man, 18,.10.2004 kl. 18.20 +0200, skrev Radek Doulík:
> Hi Kjartan,
> 
> thanks for your patch. It looks OK, only the following part looks like
> typo.
> 
> > -               }
> > +               }60
> > +
> 
> Also the inline keyword removal fromhtml_clueflow_get_halignment
> declaration introduces another gcc warning.
> html_clueflow_get_halignment implementation need to be moved before
> 1st place where we call it.
> 
> It's OK to commit after these two minor issues are fixed.
> 
I'll fix those two and commit. gnome-2-8 or just HEAD?

> Cheers
> Radek
> 
> BTW, what is this sparse? Is it some code analyzer or what?
> 
yeah, it's a code analyzer which is used extensively in the kernel to
catch various kinds of bugs and other types of problems wrt type
confusion etc. Morten Welinder has been supplying patches and a wrapper
script that makes it easier to run it against any project. It's as easy
as CC=cgcc ./configure; make 2>warnings (you have to install the script
manually after compiling and installing sparse)

Cheers
Kjartan