Re: [evolution-patches] [shell] Patch for #56484

[Sarfraaz Ahmed <asarfraaz novell com>]

Hi NotZed,

I tried implementing the CreateControls to hookup the control window, but I didnt anticipate one particular scenario.Since, the CreateControls gets called only when the exchange button is clicked on, i am not able to prompt for password, in the instance when the user clicks on his mail account in the mailer view, before clicking the exchange button. The user is now supposed to click on exchange button, then the exchange account name, enter the password and then go back to the mailer component to read the mails. This behaviour doesnt look good, since its the mailer component that would usually be active and not the exchange view. I tried adding my patch for set_interactive, and it solves this issue.

Please let me know your thoughts on this.

On Wed, 2004-05-19 at 15:44 +0800, Not Zed wrote:

This shouldn't be required anymore.

The component can imply this information from when the createControls method is first invoked.

This is how the mailer does it, and it appears to be pretty solid and reliable.

Either that, or just always be interactive; the original reason it was for has sort of gone away now, if i remember some discussions we had in a meeting a few weeks (months?) ago about this very thing.

Michael

On Wed, 2004-05-19 at 12:52 +0530, Sarfraaz Ahmed wrote:

Hi,

This patch fixes the evo-exchange bug #56484.

This patch includes the code for implementing the set_interactive call in e-shell.c. This function sends the "interactive" message to all the shell components.

Please review this and let me know if this is fine to commit.

            Thanks
                                        -- Sarfraaz Ahmed <asarfraaz novell com>

Michael Zucchi <notzed ximian com> Ximian Evolution and Free Software Developer

Novell, Inc.

            Thanks
                                        -- Sarfraaz Ahmed <asarfraaz novell com>