Re: [evolution-patches] [shell] Patch for #56484

[Sarfraaz Ahmed <asarfraaz novell com>]

Yeah, the component can imply the information when the createControls method is called. But, the interactive method, is also sending the EShellWindow as a parameter to the component, which the component can use as a parent for its guis. In exchange, we use the EShellWindow as the parent for some GUIs [ the oof gui ].  I guess, the component can still ignore this interactive method if needed, and so would not need any changes in the other components. But since exchange needs the EShellWindow, we might need the interactive method.

Please let me know your thoughs on this.

On Wed, 2004-05-19 at 15:44 +0800, Not Zed wrote:

This shouldn't be required anymore.

The component can imply this information from when the createControls method is first invoked.

This is how the mailer does it, and it appears to be pretty solid and reliable.

Either that, or just always be interactive; the original reason it was for has sort of gone away now, if i remember some discussions we had in a meeting a few weeks (months?) ago about this very thing.

Michael

On Wed, 2004-05-19 at 12:52 +0530, Sarfraaz Ahmed wrote:

Hi,

This patch fixes the evo-exchange bug #56484.

This patch includes the code for implementing the set_interactive call in e-shell.c. This function sends the "interactive" message to all the shell components.

Please review this and let me know if this is fine to commit.

            Thanks
                                        -- Sarfraaz Ahmed <asarfraaz novell com>

Michael Zucchi <notzed ximian com> Ximian Evolution and Free Software Developer

Novell, Inc.

            Thanks
                                        -- Sarfraaz Ahmed <asarfraaz novell com>