On Mon, 2004-05-10 at 22:21, Not Zed wrote: > On Mon, 2004-05-10 at 12:49 -0500, Phil Goembel wrote: > > Evolution does not import iCalendar files correctly if > > they contain folded lines (continuations) starting with > > tabs. > > > > I believe the following patch will fix the problem, although I have > > not tested it (I do not have a build environment set up). > > > > I was asked to submit this patch by a ximian person (Gerardo Marin). > > The bug report is at http://bugzilla.ximian.com/show_bug.cgi?id=55561 > > > > p.s. isblank() may not be portable to all platforms supported by evolution? > > If not, an explicit test for each of the iCalendar whitespace characters > > (' ' and '\t') could be done. Might be more appropriate anyway, since isblank() > > could change. > Yep it should be an explicit test, especially since isblank is a GNU > libc extension. > Ok. I've attached a patch using the explicit character tests. > Could you also include a ChangeLog entry please (include the patch > number and maybe a reference to the rfc). I'm not sure what a Changelog entry should look like. By patch number do you mean bug number? Here is what I think I would put in the change log: "Support the use of tab characters for folding lines, as specified in RFC 2445, section 4.1 (this fixes bug 55561)" Since I am not a developer, and I don't have a working development environment set up, I haven't tested this patch (I got errors when I tried ./configure in the evo base directory). I guess I was hoping that someone else would be willing to test the patch and make it official. Should this patch have been submitted to the hackers list instead of the patches list?
Attachment:
signature.asc
Description: This is a digitally signed message part