[evolution-patches] ical import patch



Evolution does not import iCalendar files correctly if
they contain folded lines (continuations) starting with 
tabs. 

I believe the following patch will fix the problem, although I have
not tested it (I do not have a build environment set up).

I was asked to submit this patch by a ximian person (Gerardo Marin).
The bug report is at http://bugzilla.ximian.com/show_bug.cgi?id=55561

p.s. isblank() may not be portable to all platforms supported by evolution?
If not, an explicit test for each of the iCalendar whitespace characters 
(' ' and '\t') could be done. Might be more appropriate anyway, since isblank()
could change.

--- icalparser.c.old    Mon Jul 23 18:30:11 2001
+++ icalparser.c        Sun Mar 14 03:39:01 2004
@@ -498,10 +498,10 @@
  
   
        /* If the output line ends in a '\n' and the temp buffer
-          begins with a ' ', then the buffer holds a continuation
+          begins with whitespace (a ' ' or a '\t'), then the buffer holds
a continuation
           line, so keep reading.  */
  
-       if  ( line_p > line+1 && *(line_p-1) == '\n' && impl->temp[0] == ' ') {
+       if  ( line_p > line+1 && *(line_p-1) == '\n' &&
isblank(impl->temp[0]) ) {
  
             impl->continuation_line = 1;


Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]