Re: [evolution-patches] GNOME about box
- From: Not Zed <notzed ximian com>
- To: JP Rosevear <jpr novell com>
- Cc: William Jon McCann <mccann jhu edu>, Rodney Dawes <dobey ximian com>, evolution-patches lists ximian com
- Subject: Re: [evolution-patches] GNOME about box
- Date: Mon, 10 May 2004 22:13:14 +0800
All I can add is another vote for the YUCK camp.
Aren't we in UI freeze? :P
On Mon, 2004-05-10 at 09:38 -0400, JP Rosevear wrote:
On Thu, 2004-05-06 at 15:53 -0400, William Jon McCann wrote:
> William Jon McCann wrote:
> > Rodney Dawes wrote:
> >
> >> It's not necessary really. It just means we need an extra file around to
> >> compile for a static area. Everything will get relinked anyway when you
> >> change it. It doesn't matter which of the two files it is in, in the
> >> end. It just seems extraneous to keep two extra files for a single
> >> function, just so we can keep the static array of strings out of the
> >> file where it actually gets used anyway.
> >
> >
> > Ok. Updated patch attached.
>
> Drat. Updated again so that it doesn't use gchar, doesn't explicitly
> compare against NULL in truth tests, and doesn't rely on C99.
Well the authors list still isn't NULL terminated, and i changed
e-shell-window.c a bit so it didn't quite apply, but after fiddling and
adding some documenter and translator credits it looks ok and falls in
with the other de-branding stuff I already did. Anyone else have
comments before I commit this? Jeff, Rodney?
-JP
--
JP Rosevear <jpr novell com>
Novell, Inc.
_______________________________________________
Evolution-patches mailing list
Evolution-patches lists ximian com
http://lists.ximian.com/mailman/listinfo/evolution-patches
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]