Re: [evolution-patches] GNOME about box

[William Jon McCann <mccannwj pha jhu edu>]

Hi,

Rodney Dawes wrote:
> On Enj , 2004-05-06 at 13:05 -0400, William Jon McCann wrote:
> > The current about box is really cool but it has a few problems.
> >
> >  - Not themeable
>
> Right. It's branding, which isn't meant to be themeable. :)

I mean that it doesn't follow the GNOME themes like: hi color, low 
contrast, etc... This is a problem for visually impared people.

> >  - Does not scale with font size (clips off fonts larger than or equal 
> > to 14pts)
> >  - Not accessible
>
> It's accessible in as much as it needs to be. You can use the keyboard
> to open it, and any keypress closes it.

It seems that the text is rendered onto the background.  I think that 
means that the text cannot be used in a screen reader or anything.  The 
text scrolls by at a fixed speed - anyone with non-standard reading is 
going to have a difficult time.

> >  - Doesn't include documentor or translator credits
>  
> They are all included in the same list. Not that they are all there, but
> they would be in the same list of names still.

Oh, ok.

> >  - Closes on any key press or mouse click
> >  - Doesn't conform to the HIG
> >  - Can't quickly view credits list
> >
> > Here is a patch to implement the standard (and yes, possibly boring) 
> > about dialog.
>
> What does this look like with your patch applied? I'm guessing the
> dialog is going to be too tall to be of good use with the current single
> list of names.

No, the names are in the Credits window with a scrollbar.  Seems fine to 
me.  Will be even better if we can split out the translators and 
documentors.

> > I have taken the liberty of adding my name to the credits list.
>
> Perhaps all the names should be split up into the
> authors/translators/documentors so that the dialog is put to proper use.

Yes, I agree.  I don't know who is what, however.

> Also, you probably want to get rid of e-shell-about-box.[ch] entirely,
> and just move the code to create the about box into where
> e_shell_about_box_new () is called currently.

That is fine with me.  However, it may be good to keep the list of names 
in a separate file so that e-shell-window-command.c doesn't need to be 
touched when a name is added.

Jon