Re: [evolution-patches] #53433 : Slider not changing the timeout value....

[Chris Toshok <toshok ximian com>]

patch looks fine to me..  just a few minor quibbles.

this block could be axed entirely, as the blank line should stay and the
top change is just addition of space at the end of the line:

@@ -449,10 +457,9 @@
 						 GTK_MESSAGE_ERROR,
 						 GTK_BUTTONS_OK,
 						 _("Could not perform query on Root DSE"));
-		g_signal_connect (dialog, "response", G_CALLBACK(gtk_widget_destroy), NULL);
+		g_signal_connect (dialog, "response", G_CALLBACK(gtk_widget_destroy), NULL);		
 		gtk_widget_show (dialog);
 	}
-
 	return ldap_error;
 }


Also, this patch just fixes the UI - there are remaining issues in
getting the timeout to be used in the backend.

go ahead and commit with the above diff removed, and thanks for the
patch :)

Chris

On Sun, 2004-03-28 at 15:30 +0530, hpnadig wrote:
> This one is the patch for the Time-out slider in the Addressbook (LDAP)
> properties - search tab. Solves #53433.
> 
> This patch sets the slider display right, and connects it. 
> 
> Attached is the diff.
> 
>  - h.p