Re: [evolution-patches] debugging for GW messages

[Not Zed <notzed ximian com>]

ahaaah, yeah, it sounds beneficial, although i did misread it the first
time.  But its really up to you, since i wont be debugging it :)

On Mon, 2004-03-29 at 16:54 +0200, Rodrigo Moya wrote:
> On Thu, 2004-03-18 at 09:00 +0800, Not Zed wrote:
> 
> > I think ... you should still make it a compile time option.  Even if it
> > isn't run, it makes the code bulkier and slower (sometimes by quite a
> > lot - the g* assert stuff can be a significant overhead).  And it
> > shouldn't be needed to be compiled in forever.
> > 
> so, should I leave it as it was, having --enable-debug enable all g_*
> checks, and no debug stuff at all if not specified?
> 
> What I removed was:
> 
> dnl --- Debug
> flags                                                             
> AC_ARG_ENABLE(debug,                                                            
>               [  --enable-debug=[no/yes] turn on debugging [default=no]],
>               enable_debug=yes,
>               enable_debug=no)                                                  
> if test "x$enable_debug" = "xyes"; then
>         DEBUG_CFLAGS="-DG_ENABLE_DEBUG"                                         
> else                                                                            
>         DEBUG_CFLAGS="-DG_DISABLE_ASSERT -DG_DISABLE_CHECKS"                    
> fi                                                                              
>                                                                                 
> AC_SUBST(DEBUG_CFLAGS)                                                          
> 
> so, we could have it set the -DG_DISABLE/ENABLE flags to CFLAGS instead of
> DEBUG_CFLAGS, thus working for all components at once.
> 
> does that sound ok?
> 
> cheers
>