[evolution-patches] [shell]patch to fix focus issue of Account Assistant

[Eric Zhao <eric zhao sun com>]

Hi,
   I posted this patch a month ago, but has no response. Would you
please spend little time reviewing it? Thanks!

Atttached is a patch to fix the Tab navigation bug of Account
Assistant, which can be reproduced by the following steps:
(1) Invoke  your evo,
(2) Select Tool->Settings...
(3) Select mail Account->Add to open Account Assistant
After the Account Assistant is initiated, you can find that using Tab 
key to navigate around "Cancel", "Forward" buttons is impossible.

   This bug is caused by the following code in
evolution/mail/mail-account-gui.c:618 
        gtk_widget_grab_focus (GTK_WIDGET (gui->transport.hostname));
This sentence transfers the focus to the hostname edit, but when
this function is called, the wizard is just on the start page, and
the hostname edit is unvisible, so Tab navigation failed.

   Also I found that the code can't get the expected result -- set focus
to the host edit when the wizard is on the "Sending Email" page. So I
just commented this sentence.


-- 
Eric Zhao <eric zhao sun com>

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/mail/ChangeLog,v
retrieving revision 1.3188
diff -u -r1.3188 ChangeLog
--- ChangeLog	25 Mar 2004 13:02:13 -0000	1.3188
+++ ChangeLog	29 Mar 2004 07:44:10 -0000
@@ -1,3 +1,8 @@
+2004-03-29  Eric Zhao  <eric zhao sun com>
+
+	* mail-account-gui.c: (transport_type_changed): Commented grabbing
+	focus on hostname edit, fix the focus issue of Account Assistant.
+
 2004-03-25  Sivaiah Nallagatla <snallagatla novell com>
 
 	* Makefile.am : remove local-config.glade from glade_DATA as it 
Index: mail-account-gui.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/mail-account-gui.c,v
retrieving revision 1.152
diff -u -r1.152 mail-account-gui.c
--- mail-account-gui.c	25 Mar 2004 06:56:12 -0000	1.152
+++ mail-account-gui.c	29 Mar 2004 07:44:35 -0000
@@ -653,7 +653,7 @@
 		
 		label = glade_xml_get_widget (gui->xml, "transport_host_label");
 		if (CAMEL_PROVIDER_ALLOWS (provider, CAMEL_URL_PART_HOST)) {
-			gtk_widget_grab_focus (GTK_WIDGET (gui->transport.hostname));
+			/*gtk_widget_grab_focus (GTK_WIDGET (gui->transport.hostname));*/
 			gtk_widget_show (GTK_WIDGET (gui->transport.hostname));
 			gtk_widget_show (label);
 		} else {