Re: [evolution-patches] Seeking patch review

[Kidd Wang <kidd wang sun com>]

Good idea. I've revised the patch and checked it in. Thanks a lot:-)

Rodrigo Moya wrote:

> > > -
> > > +	
> > > +	/* Alt + Arrow Keys to move a selected event through time lines */
> > > +	if ((keyval == GDK_Up || keyval == GDK_KP_Up)
> > > +			&&((event->state & GDK_SHIFT_MASK) != GDK_SHIFT_MASK)
> > > +			&&((event->state & GDK_CONTROL_MASK) != GDK_CONTROL_MASK)
> > > +			&&((event->state & GDK_MOD1_MASK) == GDK_MOD1_MASK)) {
> > > +		return e_day_view_event_move ((ECalendarView *) day_view, E_CAL_VIEW_MOVE_UP);
> > > +	}
> > > +	
> > > +	if ((keyval == GDK_Down || keyval == GDK_KP_Down)
> > > +			&&((event->state & GDK_SHIFT_MASK) != GDK_SHIFT_MASK)
> > > +			&&((event->state & GDK_CONTROL_MASK) != GDK_CONTROL_MASK)
> > > +			&&((event->state & GDK_MOD1_MASK) == GDK_MOD1_MASK)) {
> > > +		return e_day_view_event_move ((ECalendarView *) day_view, E_CAL_VIEW_MOVE_DOWN);
> > > +	}
> > > +	
> > > +	if ((keyval == GDK_Left || keyval == GDK_KP_Left)
> > > +			&&((event->state & GDK_SHIFT_MASK) != GDK_SHIFT_MASK)
> > > +			&&((event->state & GDK_CONTROL_MASK) != GDK_CONTROL_MASK)
> > > +			&&((event->state & GDK_MOD1_MASK) == GDK_MOD1_MASK)) {
> > > +		return e_day_view_event_move ((ECalendarView *) day_view, E_CAL_VIEW_MOVE_LEFT);
> > > +	}
> > > +	
> > > +	if ((keyval == GDK_Right || keyval == GDK_KP_Right)
> > > +			&&((event->state & GDK_SHIFT_MASK) != GDK_SHIFT_MASK)
> > > +			&&((event->state & GDK_CONTROL_MASK) != GDK_CONTROL_MASK)
> > > +			&&((event->state & GDK_MOD1_MASK) == GDK_MOD1_MASK)) {
> > > +		return e_day_view_event_move ((ECalendarView *) day_view, E_CAL_VIEW_MOVE_RIGHT);
> > > +	}
> > > +	
> > >      
> wouldn't all this be better a if/else if set of statements?
>
> apart from that, it looks ok.
>
> cheers
>
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches
>