Re: [evolution-patches] Seeking patch review

[Rodrigo Moya <rodrigo ximian com>]

On Fri, 2004-03-26 at 16:56 +0800, Kidd Wang wrote:

> Hi, Rodrigo
> 
> Would you please spend some time to have a look at this patch?
> Although it seems to be a little bit long, the patch is pretty simply.
> 

> > -
> > +	
> > +	/* Alt + Arrow Keys to move a selected event through time lines */
> > +	if ((keyval == GDK_Up || keyval == GDK_KP_Up)
> > +			&&((event->state & GDK_SHIFT_MASK) != GDK_SHIFT_MASK)
> > +			&&((event->state & GDK_CONTROL_MASK) != GDK_CONTROL_MASK)
> > +			&&((event->state & GDK_MOD1_MASK) == GDK_MOD1_MASK)) {
> > +		return e_day_view_event_move ((ECalendarView *) day_view, E_CAL_VIEW_MOVE_UP);
> > +	}
> > +	
> > +	if ((keyval == GDK_Down || keyval == GDK_KP_Down)
> > +			&&((event->state & GDK_SHIFT_MASK) != GDK_SHIFT_MASK)
> > +			&&((event->state & GDK_CONTROL_MASK) != GDK_CONTROL_MASK)
> > +			&&((event->state & GDK_MOD1_MASK) == GDK_MOD1_MASK)) {
> > +		return e_day_view_event_move ((ECalendarView *) day_view, E_CAL_VIEW_MOVE_DOWN);
> > +	}
> > +	
> > +	if ((keyval == GDK_Left || keyval == GDK_KP_Left)
> > +			&&((event->state & GDK_SHIFT_MASK) != GDK_SHIFT_MASK)
> > +			&&((event->state & GDK_CONTROL_MASK) != GDK_CONTROL_MASK)
> > +			&&((event->state & GDK_MOD1_MASK) == GDK_MOD1_MASK)) {
> > +		return e_day_view_event_move ((ECalendarView *) day_view, E_CAL_VIEW_MOVE_LEFT);
> > +	}
> > +	
> > +	if ((keyval == GDK_Right || keyval == GDK_KP_Right)
> > +			&&((event->state & GDK_SHIFT_MASK) != GDK_SHIFT_MASK)
> > +			&&((event->state & GDK_CONTROL_MASK) != GDK_CONTROL_MASK)
> > +			&&((event->state & GDK_MOD1_MASK) == GDK_MOD1_MASK)) {
> > +		return e_day_view_event_move ((ECalendarView *) day_view, E_CAL_VIEW_MOVE_RIGHT);
> > +	}
> > +	
wouldn't all this be better a if/else if set of statements?

apart from that, it looks ok.

cheers