Re: [evolution-patches] mail HIG patch

[Martyn Russell <ginxd btopenworld com>]

On Wed, 2004-03-24 at 22:52, Rodney Dawes wrote:
> On Mër , 2004-03-24 at 10:32 +0800, Not Zed wrote:
> Yeah. Of course, with camel and mail being so actively developed, it is
> a pain in the ass trying to keep the ChangeLog diff in sync. So, I've
> not been putting them in the patch, and just waiting until I can commit
> the code.
> 

Yea, don't I know it :P

> > The ssl settings seem to be changed as to what is shown/hidden, and i
> > dont think they should be (some remnants of the previous patch?).
> 
> Indeed this was a remnant of the old patch. I didn't notice it, because
> the changes were working, and it wasn't obviously wrong or right to me.
> Though, after reverting back to the current CVS code, it doesn't work,
> either. And playing around with the code in my previous patch, wasn't
> working so well. In fact, I'm rather surprised that the code ever did
> the right thing at all, after digging much deeper into the issue.
> Anyway, I've fixed it up a bit, and the new patch in this mail fixes the
> ssl stuff to be shown/hidden properly.
> 

Yea, this one is interesting, this was the hardest part to test.  I hade
to run ./configure to change the SSL options each time (unless you guys
know a quicker way?).  

>From what I gathered, originally, there was a warning when SSL was not
supported, that is what is hidden/shown.  I did improve on it and it
needed a few code changes to work better, but if it not needed, so be it
:)

Dobey, lads, thanks for the work/committing this!

Regards,
Martyn