Re: [evolution-patches] mail HIG patch

[Jeffrey Stedfast <fejj ximian com>]

On Tue, 2004-03-23 at 13:46 -0500, Rodney Dawes wrote:

> Here is a modified version of this patch to handle all of the necessary
> code changes as well, and to fix a few spacing and alignment issues, as
> well as a problem where one of the container widgets that was being used
> in the account gui code was removed. The ChangeLog entries are not in
> this patch, because Conflicting changes suck, and the mailer and camel
> code is changing enough right now, that I'd rather just write the
> entries when I commit.
>
> If there are any issues with this, please speak up now. Anna gave a
> quick review of the visible changes this morning, and was happy.
>
> -- dobey
>
> On Die , 2004-03-14 at 17:50 +0000, Martyn Russell wrote:
> > Dobey et al,
> > 
> > Following our earlier discussion about needing the HIG patches now, I
> > have blown the cobwebs of this patch and spent the afternoon bringing it
> > back to life :)
> > 
> > It seems ok.
> > If you need anything further, let me know.
> > 
> > Regards,
> > Martyn

+               /* security */
+               frame = glade_xml_get_widget (gui->xml, "transport_security_frame");
+               if (CAMEL_PROVIDER_ALLOWS (provider, CAMEL_URL_PART_AUTH) &&
+                   !CAMEL_PROVIDER_NEEDS (provider, CAMEL_URL_PART_AUTH))
+                       gtk_widget_show (frame);
+               else 
+                       gtk_widget_hide (frame);

this bit is wrong. if the transport provider requires auth, the frame for auth will be hidden

actually, why is this hide/show of the security frames part of this patch? it's not really anything to do with HIGification and kinda worries me since it's hard to tell if it's really right.

Anyways, lemme apply the patch and take a look at stuff I guess. trying to read massive xml blob diffs is impossible.

Jeff