Re: [evolution-patches] mail HIG patch

[Not Zed <notzed ximian com>]

On Wed, 2004-03-24 at 17:52 -0500, Rodney Dawes wrote:

> On Mër , 2004-03-24 at 10:32 +0800, Not Zed wrote:
> > What does 'gtk_window_present()' do?
> > Does it do a show?  Or is it just a less-aptly-named window.raise?
> 
> It does a show, raise, and then puts the window on the current
> workspace.
> 
> > And do you really have to do a realise before setting border sizes?
> > Seems a bit hacky to have to do that.
> 
> Unfortunately, I do, or the border sizes aren't getting recognized. I
> have no idea why. I presume it's a weird GTK+ bug. 
> 
> > ChangeLogs?
> 
> Yeah. Of course, with camel and mail being so actively developed, it is
> a pain in the ass trying to keep the ChangeLog diff in sync. So, I've
> not been putting them in the patch, and just waiting until I can commit
> the code.
> 
> > The ssl settings seem to be changed as to what is shown/hidden, and i
> > dont think they should be (some remnants of the previous patch?).
> 
> Indeed this was a remnant of the old patch. I didn't notice it, because

See, it was worth pointing out :)

> the changes were working, and it wasn't obviously wrong or right to me.
> Though, after reverting back to the current CVS code, it doesn't work,
> either. And playing around with the code in my previous patch, wasn't
> working so well. In fact, I'm rather surprised that the code ever did
> the right thing at all, after digging much deeper into the issue.
> Anyway, I've fixed it up a bit, and the new patch in this mail fixes the
> ssl stuff to be shown/hidden properly.

Ok, looks fine, please commit.

 Michael