Re [1] : [evolution-patches] Bug 27639 : UI bug in create VFolder from search

[hpnadig <hp ndeepak info>]

On Mon, 2004-03-15 at 13:27 -0500, Jeffrey Stedfast wrote:

> Couple things:
> 
> 1. for future reference, please include a ChangeLog (generally
> referencing which bugzilla bug it fixed along with a description of
> how it was fixed, etc)

Oops! sorry for that... changelog + diff attached with this mail.

> 
> 2. my guess is that there is similar filter/vfolder editor dialog code
> in filter/ that would also need to be "fixed" to default to a larger
> size?
> 
> 3. I'm not sure this is the ideal (long-term) way to fix it (maybe it
> is, maybe it isn't). I just glanced over the bugzilla entry and saw
> that ~year ago Anna was working on some new filter GUI design or
> something. Not sure what ever became of that, but she might have some
> useful thoughts on the matter (like perhaps we shouldn't use a
> scrolled window at all?). For a short-term solution, I think your
> approach is definetely OK tho especiallysince a more long-term
> solution might involve more than we can afford for the 2.0 release.

well, given a chance, I'll be interested to try that...

thanks,

 - h.p.

> 
> other than that, the patch looks good to me :-)
> 
> Assuming UI is OK with it (and once it has a ChangeLog entry), I'd be
> OK with committing it.
> 
> Anna?
> 
> Jeff
> 
> On Mon, 2004-03-15 at 23:39 -0500, hpnadig wrote:
> 
> 
> > hi,
> > 
> > It needed just a small change in the window size... done that.
> > 
> > -- 
> > - hpnadig
-- 

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/mail/ChangeLog,v
retrieving revision 1.3148
diff -u -r1.3148 ChangeLog
--- ChangeLog   8 Mar 2004 21:12:45 -0000       1.3148
+++ ChangeLog   15 Mar 2004 19:41:28 -0000
@@ -1,3 +1,7 @@
+2004-03-16  hpnadig  <hp ndeepak info>
+
+       * mail-vfolder.c: (vfolder_gui_add_rule): Just Changed the window size, to get the 'remove' widget show properly.
+
 2004-03-08  Jeffrey Stedfast  <fejj ximian com>
  
        * em-folder-tree.c (emft_create_folder): New async function to

Index: mail-vfolder.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/mail-vfolder.c,v
retrieving revision 1.117
diff -u -p -r1.117 mail-vfolder.c
--- mail-vfolder.c      20 Feb 2004 09:26:49 -0000      1.117
+++ mail-vfolder.c      15 Mar 2004 19:44:28 -0000
@@ -1065,7 +1065,7 @@ vfolder_gui_add_rule(VfolderRule *rule)
        gtk_container_set_border_width (GTK_CONTAINER (gd), 6);
        gtk_box_set_spacing ((GtkBox *) gd->vbox, 6);
        g_object_set(gd, "allow_shrink", FALSE, "allow_grow", TRUE, NULL);
-       gtk_window_set_default_size (GTK_WINDOW (gd), 500, 500);
+       gtk_window_set_default_size (GTK_WINDOW (gd), 600, 600);
        gtk_box_pack_start((GtkBox *)gd->vbox, w, TRUE, TRUE, 0);
        gtk_widget_show((GtkWidget *)gd);
        g_object_set_data_full(G_OBJECT(gd), "rule", rule, (GtkDestroyNotify)g_object_unref);