Re: [evolution-patches] Bug 27639 : UI bug in create VFolder from search

[Jeffrey Stedfast <fejj ximian com>]

Couple things:

1. for future reference, please include a ChangeLog (generally referencing which bugzilla bug it fixed along with a description of how it was fixed, etc)

2. my guess is that there is similar filter/vfolder editor dialog code in filter/ that would also need to be "fixed" to default to a larger size?

3. I'm not sure this is the ideal (long-term) way to fix it (maybe it is, maybe it isn't). I just glanced over the bugzilla entry and saw that ~year ago Anna was working on some new filter GUI design or something. Not sure what ever became of that, but she might have some useful thoughts on the matter (like perhaps we shouldn't use a scrolled window at all?). For a short-term solution, I think your approach is definetely OK tho especiallysince a more long-term solution might involve more than we can afford for the 2.0 release.

other than that, the patch looks good to me :-)

Assuming UI is OK with it (and once it has a ChangeLog entry), I'd be OK with committing it.

Anna?

Jeff

On Mon, 2004-03-15 at 23:39 -0500, hpnadig wrote:

> hi,
>
> It needed just a small change in the window size... done that.
>
> -- 
> - hpnadig