[evolution-patches] small fix for contact-editor
- From: Sivaiah N <snallagatla novell com>
- To: evolution-patches ximian com
- Subject: [evolution-patches] small fix for contact-editor
- Date: 14 Mar 2004 13:09:34 +0530
Hi,
Attached small patch prevents indexing addresses array beyond its size
limit, hence fixes some assertion failures in e_contact_field_name call.
Thanks,
Sivaiah
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/addressbook/ChangeLog,v
retrieving revision 1.1612
diff -u -r1.1612 ChangeLog
--- ChangeLog 11 Mar 2004 01:12:38 -0000 1.1612
+++ ChangeLog 14 Mar 2004 07:42:47 -0000
@@ -1,3 +1,8 @@
+2004-03-14 Sivaiah Nallagatla <snallagatla novell com>
+ * gui/contact-editor/e-contact-editor.c (enable_writable_fields) :
+ loop only up to < G_N_ELEMENTS instead of <= G_N_ELEMENTS. Prevents
+ out of bound indexing of addresses array
+
2004-03-10 Chris Toshok <toshok ximian com>
* gui/widgets/eab-contact-display.c (render_address): #if 0 this,
Index: gui/contact-editor/e-contact-editor.c
===================================================================
RCS file: /cvs/gnome/evolution/addressbook/gui/contact-editor/e-contact-editor.c,v
retrieving revision 1.174
diff -u -r1.174 e-contact-editor.c
--- gui/contact-editor/e-contact-editor.c 10 Mar 2004 22:33:34 -0000 1.174
+++ gui/contact-editor/e-contact-editor.c 14 Mar 2004 07:42:49 -0000
@@ -3164,7 +3164,7 @@
g_hash_table_insert (supported_hash, field, field);
}
- for (i = 0; i <= G_N_ELEMENTS (addresses); i ++) {
+ for (i = 0; i < G_N_ELEMENTS (addresses); i ++) {
if (!strcmp (field, e_contact_field_name (addresses[i]))) {
editor->address_editable [i] = TRUE;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]