Re: [evolution-patches] #55299: Can't change several attachment property in Mail

[Jeffrey Stedfast <fejj ximian com>]

On Fri, 2004-03-12 at 11:19 +0800, Not Zed wrote:

> > - (GtkWidget *)(menu_item->data)
> > 
> > to be more consistant with the rest of the mailer code, just use:
> > (GtkWidget *) menu_item->data
>
> With or without the gratutous non-k&r waste of space :)
>
> > - doing menu_item->data is just gross and is very likely to break if
> > we ever decide to add a new menu item or change the order of the menu
> > items later (which is possible). A better solution would involve
> > either naming the menu items or having a table somewhere that defined
> > the order of the menu items and using that table to get the proper
> > one.
>
> Or the esiest, it should just keep a reference to the item widget in its
> private area.

er, doh. why didn't I think of that? yes, this would also be fine.

Jeff

> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches