Re: [evolution-patches] fix for 57653 : toolbar visibility

[Not Zed <notzed ximian com>]

On Wed, 2004-06-02 at 00:16 -0400, Jeffrey Stedfast wrote:
> On Tue, 2004-06-01 at 23:56, Not Zed wrote:
> > Sweet.  Looks good to me.
> > 
> > I would only suggest you use
> >   prop[0] == '1'
>
> wouldn't you want:
> prop[0] != '0' ?

Either way should work since the prop will either be "1" or "0".

Its not the same as C.

> same reason you don't check foo == TRUE, you check foo != FALSE
Well you shouldn't do that, if foo is a bool its just you check (foo) or !foo.  In reality the compiler will implicitly check (foo != 0).

TRUE and FALSE aren't part of the C anyway (at least not ANSI-C), they're just convenience macro's defined by some libraries (e.g. X) for the language defined values of 1 and 0.

> > 
> > rather than
> >   strcmp(prop, "1") == 0
> > 
> > but its not really important (strcmp on gcc will be optimised to be
> > something similar anyway).
> > 
> > I'd say give 24 hours from when you posted it for anyone else to
> > object, otherwise go for it.
> > 
> > 
> > On Tue, 2004-06-01 at 16:45 -0400, William Jon McCann wrote: 
> > > Shoot.  This one doesn't leak the prop string.
> > > 
> > > Jon
> > > 
> > > William Jon McCann wrote:
> > > > I have updated the patch to address Michael's concern about multiple 
> > > > open windows.
> > > > 
> > > > The toolbar status is now saved to gconf only in 
> > > > e_shell_window_save_defaults().
> > > > 
> > > > Does this look ok?
> > > > 
> > > > Thanks,
> > > > Jon
> > > > 
> > 
> > -- 
> > 
> > Michael Zucchi <notzed ximian com>
> > 
> > Ximian Evolution and Free Software
> > Developer

--

Michael Zucchi <notzed ximian com> Ximian Evolution and Free Software Developer