Re: [evolution-patches] fix for 57653 : toolbar visibility

[Not Zed <notzed ximian com>]

Sweet.  Looks good to me.

I would only suggest you use
  prop[0] == '1'

rather than
  strcmp(prop, "1") == 0

but its not really important (strcmp on gcc will be optimised to be something similar anyway).

I'd say give 24 hours from when you posted it for anyone else to object, otherwise go for it.


On Tue, 2004-06-01 at 16:45 -0400, William Jon McCann wrote:
> Shoot.  This one doesn't leak the prop string.
>
> Jon
>
> William Jon McCann wrote:
> > I have updated the patch to address Michael's concern about multiple 
> > open windows.
> > 
> > The toolbar status is now saved to gconf only in 
> > e_shell_window_save_defaults().
> > 
> > Does this look ok?
> > 
> > Thanks,
> > Jon
> >

--

Michael Zucchi <notzed ximian com> Ximian Evolution and Free Software Developer