Re: [evolution-patches] Resent in text format - gw connector update for the GW server fixes in recurrence, group events.

[Rodrigo Moya <rodrigo novell com>]

On Mon, 2004-07-26 at 16:09 +0530, Harish Krishnaswamy wrote:
> hi,
> 
> On Mon, 2004-07-26 at 12:58, Rodrigo Moya wrote:
> > > +				e_cal_comp = e_gw_item_to_cal_component (item, priv->default_zone); 
> > > +				e_cal_component_commit_sequence (e_cal_comp);
> > > +				sanitize_component (backend, e_cal_comp, g_ptr_array_index (uid_array, i));
> > >
> > probably would be better to call commit_sequence after
> > sanitize_component, right?
> The static function sanitize_component sanitizes only the gw-specific
> properties like container_id and gwrecordid property and requires a
> valid ecal component. hence commit_sequence is called before
> sanitize_component is invoked.
> > 
ok

> > > Index: calendar/backends/groupwise/e-cal-backend-groupwise-utils.h
> > > ===================================================================
> > > RCS file: /cvs/gnome/evolution-data-server/calendar/backends/groupwise/e-cal-backend-groupwise-utils.h,v
> > > retrieving revision 1.8
> > > diff -u -p -r1.8 e-cal-backend-groupwise-utils.h
> > > --- calendar/backends/groupwise/e-cal-backend-groupwise-utils.h	23 Jul 2004 07:01:32 -0000	1.8
> > > +++ calendar/backends/groupwise/e-cal-backend-groupwise-utils.h	23 Jul 2004 10:14:42 -0000
> > > @@ -40,8 +40,8 @@ void          e_gw_item_set_changes (EGw
> > >   * Connection-related utility functions
> > >   */
> > >  EGwConnectionStatus e_gw_connection_create_appointment (EGwConnection *cnc, const char *container, icaltimezone *default_zone, ECalComponent *comp, GSList **id_list);
> > > -EGwConnectionStatus e_gw_connection_send_appointment (EGwConnection *cnc, const char *container, icaltimezone *default_zone, ECalComponent *comp, icalproperty_method method);
> > > -EGwConnectionStatus e_gw_connection_get_freebusy_info (EGwConnection *cnc, GList *users,						       time_t start, time_t end, GList **freebusy, icaltimezone *default_zone);
> > > +EGwConnectionStatus e_gw_connection_send_appointment (EGwConnection *cnc, const char *container, ECalComponent *comp, icalproperty_method method);
> > > +EGwConnectionStatus e_gw_connection_get_freebusy_info (EGwConnection *cnc, GList *users, time_t start, time_t end, GList **freebusy, icaltimezone *default_zone);
> > >  
> > this code (having the default_zone argument) was added by Chen twice, so
> > not sure if you should be removing it. Chen?
> > 
> I have just removed the ugly whitespace between the arguments, in the
> freebusy_info function. 
>
yes, I was talking about the send_appointment function, sorry

> The default timezone parameter in e_gw_connection_send_appointment is
> being removed as Chen's patch had overlooked this function.
> 
ok, then, looks ok to me then.

cheers