Re: [evolution-patches] e-error parent fix

[Not Zed <notzed ximian com>]

ok thanks for following this up.  i think its just calling it in the wrong place/on the wrong widget.  its supposed to be doing it on each of the main toplevels that get created instead.  i'll have a look at it today.

On Tue, 2004-07-20 at 15:05 -0400, William Jon McCann wrote:
> On Tue, 2004-07-20 at 12:05 +0800, Not Zed wrote:
> > 
> > ugh ok i misread it, sorry.
> > 
> > anyway its up to the callers to set the right toplevel widget.  this
> > code shouldn't be looking for the toplevel itself.
>
> Ok, I think I understand why this isn't working.  The
> e_error_default_parent() is called in impl_createControls().  This gets
> called in e-shell-window.c:init_view().  Obviously, this occurs *before*
> the component is re-parented into the shell.
>
> So, therefore, the component does not register a top-level widget with
> e-error as the default parent.
>
> Actually, I don't think you can ever rely on a component knowing what
> the toplevel component will be before you need to use it.
>
> I think you can move the e_error_default_parent() call into e-shell-
> window.c or just have e-error look for the toplevel when needed.
>
> Jon
>
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches

--

Michael Zucchi <notzed ximian com> "born to die, live to work, it's all downhill from here" Novell's Evolution and Free Software Developer