Re: [evolution-patches] e-error parent fix

[Not Zed <notzed ximian com>]

ugh ok i misread it, sorry.

anyway its up to the callers to set the right toplevel widget.  this code shouldn't be looking for the toplevel itself.

On Mon, 2004-07-19 at 09:21 -0400, William Jon McCann wrote:
> On Mon, 2004-07-19 at 16:49 +0800, Not Zed wrote:
> > 
> > No.  It changes the logic of the code.
> > 
> > A null parent is allowed assuming you've set the parent elsewhere.
> > This completely strips out that logic.
>
> Can you please explain how this strips out that logic?  I don't think it
> does.
>
> Jon
>
>
>
> > On Mon, 2004-07-19 at 03:14 -0400, William Jon McCann wrote: 
> > > Hi,
> > > 
> > > This patch ensures that the default_parent of the e-error dialog is a
> > > toplevel widget.
> > > 
> > > Without this, mail is setting the default parent to a non-toplevel
> > > widget.  This causes gtk_window_set_transient_for() to fail and the
> > > dialog will show up in other workspaces/screens.
> > > 
> > > Is this ok to commit?
> > > 
> > > Jon
> > -- 
> > 
> > Michael Zucchi <notzed ximian com>
> > "born to die, live to work, it's
> > all downhill from here"
> > Novell's Evolution and Free
> > Software Developer
>
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches

--

Michael Zucchi <notzed ximian com> "born to die, live to work, it's all downhill from here" Novell's Evolution and Free Software Developer